Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WAGTAILTRANS_LANGUAGES_PER_SITE setting #160

Open
mikedingjan opened this issue Mar 13, 2019 · 0 comments
Open

Remove WAGTAILTRANS_LANGUAGES_PER_SITE setting #160

mikedingjan opened this issue Mar 13, 2019 · 0 comments

Comments

@mikedingjan
Copy link
Member

mikedingjan commented Mar 13, 2019

In the early days of wagtailtrans we've created a setting which allowed users to define the default and other languages of a wagtailcore.Site this behavior is very common when dealing with multiple sites.

To have a better maintainable codebase it would be great to have this as default, since it can also be used when having an instance with a single site. I think next to maintainability we will also be able to introduce some performance benefits with this.

Going forward with this we need to proper document this and have a data migration which handles this for non site language sites.

Steps to take:

  • Remove WAGTAILTRANS_LANGUAGES_PER_SITE setting
  • Remove Language.is_default, this is defined via sitelanguages
  • Create data migration
  • Update unit tests
  • Update documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant