Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: harden subscribe procs in libwaku #3246

Open
gabrielmer opened this issue Jan 21, 2025 · 0 comments
Open

chore: harden subscribe procs in libwaku #3246

gabrielmer opened this issue Jan 21, 2025 · 0 comments
Assignees

Comments

@gabrielmer
Copy link
Contributor

Background

Currently, if we call libwaku's waku_relay_subscribe N times, the message handler is set up N times and we would get N notifications per message.

We want to:

  1. Allow only one message handler to be set up. i.e if waku_relay_subscribe is called when a handler is already set for that pubsub topic, then ignore the call.

  2. Create a new proc in libwaku to enable subscription by content topic (for autosharding). Once that procedure is exposed, we should create a wrapper in waku-go-bindings where all the desired pubsub and content topics to subscribe are passed as arguments, and the wrapper handles the calls to libwaku to make it happen.

Please refer to the following Discord thread as reference

@gabrielmer gabrielmer self-assigned this Jan 21, 2025
@NagyZoltanPeter NagyZoltanPeter moved this to To Do in Waku Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do
Development

No branches or pull requests

1 participant