Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Waline 客户端 v3.5.0 版 ”文章反应“ 参数 Bug || [Bug]: Waline client v3.5.0 version "article response" parameter bug #2907

Closed
x4fa0 opened this issue Jan 17, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@x4fa0
Copy link

x4fa0 commented Jan 17, 2025

问题描述 | Describe the bug

  1. Waline 客户端最新版 v3.5.0 版 ”文章反应“ 参数 reaction 有 Bug。reaction: false 应是关闭文章反应,但不起作用;设置 reaction: true 才是关闭,是不是搞反了?前一版本 v3.4.0 貌似就是正常的。(博客搭建测试中还未上线)
  2. 评论框大小问题,已在讨论区提出:https://github.com/orgs/walinejs/discussions/2896

问题网站 | Website URL

https://waline.js.org/

服务部署在哪里? | Where your waline deploy?

Vercel (Default)

数据存储在哪里?| Where your comment data store?

LeanCloud(https://leancloud.app)


Problem description | Describe the bug

  1. The latest version of Waline client v3.5.0 has a bug in the "article response" parameter reaction. reaction: false should turn off the article reaction, but it does not work; setting reaction: true will turn it off. Is it reversed? The previous version v3.4.0 seems to be normal. (The blog building test is not yet online)
  2. The issue of comment box size has been raised in the discussion area: https://github.com/orgs/walinejs/discussions/2896

Question Website | Website URL

https://waline.js.org/

Where is the service deployed? | Where your waline deploy?

Vercel (Default)

Where is the data stored? | Where your comment data store?

LeanCloud(https://leancloud.app)

@x4fa0 x4fa0 added the bug Something isn't working label Jan 17, 2025
@github-actions github-actions bot changed the title [Bug]: Waline 客户端 v3.5.0 版 ”文章反应“ 参数 Bug [Bug]: Waline 客户端 v3.5.0 版 ”文章反应“ 参数 Bug || [Bug]: Waline client v3.5.0 version "article response" parameter bug Jan 17, 2025
@coolwjl
Copy link

coolwjl commented Jan 17, 2025

确实有问题,好几个参数都是反的


There is indeed a problem, several parameters are reversed

@Mister-Hope
Copy link
Member

Mister-Hope commented Jan 17, 2025

3.5.2 should fix this problem, this reverts the previous Waline client behavior

We will drop all negative boolean props (AKA a boolean value with true as default) in the near future v4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants