forked from zammad/zammad
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathexternal_data_source_spec.rb
482 lines (401 loc) · 17.4 KB
/
external_data_source_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
# Copyright (C) 2012-2024 Zammad Foundation, https://zammad-foundation.org/
require 'rails_helper'
RSpec.describe ExternalDataSource do
describe '#execute', db_adapter: :postgresql do
context 'with ElasticSearch', searchindex: true do
let(:data_option) do
create(:object_manager_attribute_autocompletion_ajax_external_data_source, :elastic_search)
.data_option
end
let(:searchterm) { SecureRandom.uuid }
let(:user1) { create(:agent, firstname: searchterm) }
let(:user2) { create(:agent, firstname: searchterm) }
before do
user1
user2
searchindex_model_reload([User])
end
it 'returns search results' do
result = described_class.new(options: data_option, render_context: {}, term: searchterm).process
expect(result).to eq([
{ value: user1.id.to_s, label: user1.email },
{ value: user2.id.to_s, label: user2.email }
])
end
end
describe 'handling configuration errors' do
let(:data_option) do
create(:object_manager_attribute_autocompletion_ajax_external_data_source, search_url: search_url)
.data_option
end
context 'when search url is nil' do
let(:search_url) { nil }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::SearchUrlMissingError)
.and(having_attributes(external_data_source: instance))
)
end
end
context 'when search url is not parsable URI' do
let(:search_url) { 'loremipsum' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::SearchUrlInvalidError)
.and(having_attributes(external_data_source: instance))
)
end
end
context 'when search url is bad URI' do
let(:search_url) { 'http://host.com?#{search.t' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::SearchUrlInvalidError)
.and(having_attributes(external_data_source: instance))
)
end
end
end
describe 'handling of external data source' do
let(:instance) { described_class.new }
let(:search_url) { 'https://dummyjson.com' }
let(:data_option) do
create(:object_manager_attribute_autocompletion_ajax_external_data_source, search_url: search_url, list_key: '')
.data_option
end
before do
allow(UserAgent).to receive(:get).and_return(UserAgent::Result.new(success: true, data: []))
end
context 'when search URL contains placeholders' do
let(:ticket) { create(:ticket) }
let(:search_url) { 'https://dummyjson.com/ticket/#{ticket.id}' } # rubocop:disable Lint/InterpolationCheck
it 'replaces placeholders correctly' do
described_class.new(options: data_option, render_context: { ticket: ticket }, term: 'term', limit: 1).process
expect(UserAgent)
.to have_received(:get)
.with("https://dummyjson.com/ticket/#{ticket.id}", anything, anything)
end
end
context 'when search term contains umlauts (#4980)' do
let(:search_term) { 'bücher' }
let(:search_url) { 'https://dummyjson.com/products/search?q=#{search.term}' } # rubocop:disable Lint/InterpolationCheck
it 'properly URL encodes search term' do
described_class.new(options: data_option, render_context: {}, term: search_term, limit: 1).process
expect(UserAgent)
.to have_received(:get)
.with("https://dummyjson.com/products/search?q=#{ERB::Util.url_encode(search_term)}", anything, anything)
end
end
context 'when http basic username and password present' do
before do
data_option[:http_basic_auth_username] = 'test_username'
data_option[:http_basic_auth_password] = 'test_password'
end
it 'sets username and password' do
described_class.new(options: data_option, render_context: {}, term: 'term', limit: 1).process
expect(UserAgent)
.to have_received(:get)
.with(anything, anything, include(user: 'test_username', password: 'test_password'))
end
end
context 'when bearer token present' do
before do
data_option[:bearer_token_auth] = 'test_bearer_token'
end
it 'sets authorization token' do
described_class.new(options: data_option, render_context: {}, term: 'term', limit: 1).process
expect(UserAgent)
.to have_received(:get)
.with(anything, anything, include(bearer_token: 'test_bearer_token'))
end
end
context 'when SSL verification flag present' do
before do
data_option[:verify_ssl] = false
end
it 'sets SSL verification flag' do
described_class.new(options: data_option, render_context: {}, term: 'term', limit: 1).process
expect(UserAgent)
.to have_received(:get)
.with(anything, anything, include(verify_ssl: false))
end
end
end
context 'with mocked response' do
let(:instance) { described_class.new }
let(:data_option) do
create(:object_manager_attribute_autocompletion_ajax_external_data_source,
list_key: list_key,
value_key: value_key,
label_key: label_key)
.data_option
end
before do
allow_any_instance_of(described_class)
.to receive(:fetch_json)
.and_return(json_response)
end
context 'with simple structure' do
let(:json_response) do
{
'items' => [
{ 'id' => 1, 'name' => 'name 1' },
{ 'id' => 2, 'name' => 'name 2' },
]
}
end
let(:list_key) { 'items' }
let(:value_key) { 'id' }
let(:label_key) { 'name' }
it 'returns correct data' do
result = described_class.new(options: data_option, render_context: {}, term: 'term').process
expect(result).to eq([
{ value: 1, label: 'name 1' },
{ value: 2, label: 'name 2' },
])
end
it 'returns limited set' do
result = described_class.new(options: data_option, render_context: {}, term: 'term', limit: 1).process
expect(result).to eq([
{ value: 1, label: 'name 1' },
])
end
end
context 'with minimal structure' do
let(:json_response) do
%w[foo bar]
end
let(:list_key) { '' }
let(:value_key) { '' }
let(:label_key) { '' }
it 'returns correct data' do
result = described_class.new(options: data_option, render_context: {}, term: 'term').process
expect(result).to eq([
{ value: 'foo', label: 'foo' },
{ value: 'bar', label: 'bar' },
])
end
end
context 'with complex structure' do
let(:json_response) do
{
'deadend' => 'yes',
'results' => {
'items' => [
{ 'data' => { 'id' => 1, 'name' => 'name 1' } },
{ 'data' => { 'id' => 2, 'name' => 'name 2' } },
{ 'data' => { 'id' => 3, 'name' => false } },
{ 'data' => { 'id' => 4, 'name' => true } },
]
}
}
end
let(:list_key) { 'results.items' }
let(:value_key) { 'data.id' }
let(:label_key) { 'data.name' }
it 'returns correct data' do
result = described_class.new(options: data_option, render_context: {}, term: 'term').process
expect(result).to eq([
{ value: 1, label: 'name 1' },
{ value: 2, label: 'name 2' },
{ value: 3, label: false },
{ value: 4, label: true },
])
end
context 'when list points to string' do
let(:list_key) { 'deadend' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ListNotArrayParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: be_nil
),
message: 'Search result list key "deadend" is not an array.'
))
)
end
end
context 'when list points to hash' do
let(:list_key) { 'results' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ListNotArrayParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: be_nil
),
message: 'Search result list key "results" is not an array.'
))
)
end
end
context 'when list points to array member' do
let(:list_key) { 'results.items.data' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ListPathParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: be_nil
),
message: 'Search result list key "results.items.data" was not found.'
))
)
end
end
context 'when list points to non existant key' do
let(:list_key) { 'nonexistant' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ListPathParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: be_nil
),
message: 'Search result list key "nonexistant" was not found.'
))
)
end
end
context 'when list fails to pick root element' do
let(:list_key) { '' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ListNotArrayParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: be_nil
),
message: 'Search result list is not an array. Please provide search result list key.'
))
)
end
end
context 'when value points to hash' do
let(:value_key) { 'data' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ItemValueInvalidTypeParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: json_response.dig('results', 'items')
),
message: 'Search result value key "data" is not a string, number or boolean.'
))
)
end
end
context 'when value points to non existant key' do
let(:value_key) { 'nonexistant' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ItemValuePathParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: json_response.dig('results', 'items')
),
message: 'Search result value key "nonexistant" was not found.'
))
)
end
end
context 'when value fails to pick root element' do
let(:value_key) { '' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ItemValueInvalidTypeParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: json_response.dig('results', 'items')
),
message: 'Search result value is not a string, a number or a boolean. Please provide search result value key.'
))
)
end
end
context 'when label points to hash' do
let(:label_key) { 'data' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ItemLabelInvalidTypeParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: json_response.dig('results', 'items')
),
message: 'Search result label key "data" is not a string, number or boolean.'
))
)
end
end
context 'when label points to non existant key' do
let(:label_key) { 'nonexistant' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ItemLabelPathParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: json_response.dig('results', 'items')
),
message: 'Search result label key "nonexistant" was not found.'
))
)
end
end
context 'when label fails to pick root element' do
let(:label_key) { '' }
it 'raises error' do
instance = described_class.new(options: data_option, render_context: {}, term: 'term')
expect { instance.process }
.to raise_error(
an_instance_of(ExternalDataSource::Errors::ItemLabelInvalidTypeParsingError)
.and(having_attributes(
external_data_source: having_attributes(
json: json_response,
parsed_items: json_response.dig('results', 'items')
),
message: 'Search result label is not a string, a number or a boolean. Please provide search result label key.'
))
)
end
end
end
end
end
end