Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTL support #37

Open
dittaeva opened this issue May 2, 2012 · 8 comments
Open

RTL support #37

dittaeva opened this issue May 2, 2012 · 8 comments
Labels

Comments

@dittaeva
Copy link
Collaborator

dittaeva commented May 2, 2012

Arabic is right to left, which doesn't work quite as it should.

@lonvia
Copy link
Collaborator

lonvia commented May 3, 2012

Two things need to be corrected:

  • copyright message should read RTL (The entire copyright string should go into one translation message and there is some bug in the handling of mixed RTL/LTR text, it seems.)
  • Search box needs to be reversed

@lonvia
Copy link
Collaborator

lonvia commented May 3, 2012

I just remembered why the copyright message is split: the acknowledgement for the HikeBike map is removed in the mobile version, so they actually need to stay split.

@dittaeva
Copy link
Collaborator Author

dittaeva commented May 3, 2012

Copyright messages should ideally change according to which layer is used, similar to the way attribution changes on openstreetmap.org now (only here you'd feasibly combine attributions). This should probably be done in #27.

@lonvia
Copy link
Collaborator

lonvia commented May 3, 2012

Additional RTL problem: route window. Needs complete rework. Will do that and the search box.

The copyright mess needs further investigation. The po files look good but on the webpage the LTR parts are on the wrong side of the LTR text.

@dittaeva
Copy link
Collaborator Author

dittaeva commented May 4, 2012

Looks like you solved the copyright message problem too, but the ", " inbetween the messages should probably be moved to the Hike&Bike message in case it is not appropriate in some languages. We should probably amend existing translations for such a minor change so they don't go fuzzy. I can do this later.

Also, the "ar" version does not look good now, the update date is borked and the site title is behind the route selection buttons.

@lonvia
Copy link
Collaborator

lonvia commented May 4, 2012

For a better "ar" version, reload the page. You were using outdated CSS styles. I have now changed the main site so that it forces the CSS to be reloaded.

If I see it correctly, the comma is adapted in style to the language, so it might only become a problem if a language does not want a comma at all.

@lonvia
Copy link
Collaborator

lonvia commented May 4, 2012

There are still some things to do for RTL:

  • If route names are in a LTR language and contain brackets, they are completely messed up. For an example see http://hiking.lonvia.de/ar/relation/1967479.
  • Help pages need to be adapted to RTL, although I don't know if it is worth the trouble before any translations of the actual help content come in.
  • Mobile version needs updating.

@dittaeva
Copy link
Collaborator Author

dittaeva commented May 4, 2012

Sorry about being mundane about the CSS.

I don't think it's necessary to handle RTL on the help pages before any RTL help pages exist. It is not like anyone can blame you for being slow on the trigger ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants