Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Selector inconsistency #35

Closed
lukerollans opened this issue Nov 19, 2014 · 0 comments
Closed

CSS Selector inconsistency #35

lukerollans opened this issue Nov 19, 2014 · 0 comments

Comments

@lukerollans
Copy link

There's an inconsistency present when passing in selectors. IE, activeClass can be passed in unqualified, but containerSelector needs to be fully qualified.

EG, this will not work

$('.post .sidebar.lower').pin({
    padding: {
        top: 10,
        bottom: 10
    },
    activeClass: 'pinned',
    containerSelector: 'pin-parent'
});

But this does

$('.post .sidebar.lower').pin({
    padding: {
        top: 10,
        bottom: 10
    },
    activeClass: 'pinned',
    containerSelector: '.pin-parent'
});

It could be argued that this is semantically correct, given the difference between the option names.. EG "Class" as opposed to "Selector".

Will open a PR for this issue if no-one else gets to it first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant