Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll into view doesn't work any more for scrollable divs #4631

Closed
kof opened this issue Dec 20, 2024 · 0 comments · Fixed by #4674
Closed

Scroll into view doesn't work any more for scrollable divs #4631

kof opened this issue Dec 20, 2024 · 0 comments · Fixed by #4674
Assignees
@istarkov
Labels
area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work prio:hotfix Something that needs immediate hotfixing type:bug Something isn't working

Comments

@kof
Copy link
Member

kof commented Dec 20, 2024 •
edited
Loading

Discord thread https://discord.com/channels/955905230107738152/1319754382908199025

For some reason .scrollIntoView only works now for document-level scrolling, but doesn't work for containers.

For simple repro:

  1. add a flex container, set overflow to hidden and width to 100vw
  2. add a bunch of elements to it so that they take more space than you can see
  3. select in navigator one of the elements and see canvas won't scroll to the elements
@kof kof added area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work prio:1 The most important thing to work on labels Dec 20, 2024
@kof kof added type:bug Something isn't working prio:hotfix Something that needs immediate hotfixing and removed prio:1 The most important thing to work on labels Dec 22, 2024
@istarkov istarkov mentioned this issue Dec 30, 2024
Merged
8 tasks
istarkov added a commit that referenced this issue Dec 30, 2024
@istarkov
fix: Scroll into view doesn't work any more for scrollable divs (#4674)
2c7cfb7 
## Description

closes  #4631

tested in Safari, FF, Chrome

## TODO:

- [x] - Menu content cause
<img width="914" alt="image"
src="https://github.com/user-attachments/assets/45567d6b-b9b4-493d-80b8-596f5c0ac650"
/>


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@istarkov istarkov

Labels
area:canvas Anything related to rendering on canvas complexity:medium Up to 1 week of work prio:hotfix Something that needs immediate hotfixing type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Scroll into view doesn't work any more for scrollable divs webstudio-is/webstudio
2 participants
@kof @istarkov