fix(testability): escape regex chars in findBindings if using exactMatch

Move the function to escape regexps to Angular.js, fix the link, and use it in
the $$testability service.

Closes angular#9595
Closes angular#9600

Author: juliemr

src/.jshintrc

@@ -54,6 +54,7 @@
     "isBoolean": false,
     "isPromiseLike": false,
     "trim": false,
+    "escapeForRegexp": false,
     "isElement": false,
     "makeMap": false,
     "size": false,

src/Angular.js

@@ -49,6 +49,7 @@
   isBoolean: true,
   isPromiseLike: true,
   trim: true,
+  escapeForRegexp: true,
   isElement: true,
   makeMap: true,
   size: true,
@@ -586,6 +587,14 @@ var trim = function(value) {
   return isString(value) ? value.trim() : value;
 };
 
+// Copied from:
+// http://docs.closure-library.googlecode.com/git/local_closure_goog_string_string.js.source.html#line1021
+// Prereq: s is a string.
+var escapeForRegexp = function(s) {
+  return s.replace(/([-()\[\]{}+?*.$\^|,:#<!\\])/g, '\\$1').
+           replace(/\x08/g, '\\x08');
+};
+
 
 /**
  * @ngdoc function

src/ng/sce.js

@@ -14,15 +14,6 @@ var SCE_CONTEXTS = {
 
 // Helper functions follow.
 
-// Copied from:
-// http://docs.closure-library.googlecode.com/git/closure_goog_string_string.js.source.html#line962
-// Prereq: s is a string.
-function escapeForRegexp(s) {
-  return s.replace(/([-()\[\]{}+?*.$\^|,:#<!\\])/g, '\\$1').
-           replace(/\x08/g, '\\x08');
-}
-
-
 function adjustMatcher(matcher) {
   if (matcher === 'self') {
     return matcher;

src/ng/testability.js

@@ -34,7 +34,7 @@ function $$TestabilityProvider() {
         if (dataBinding) {
           forEach(dataBinding, function(bindingName) {
             if (opt_exactMatch) {
-              var matcher = new RegExp('(^|\\s)' + expression + '(\\s|\\||$)');
+              var matcher = new RegExp('(^|\\s)' + escapeForRegexp(expression) + '(\\s|\\||$)');
               if (matcher.test(bindingName)) {
                 matches.push(binding);
               }

test/ng/testabilitySpec.js

@@ -88,6 +88,32 @@ describe('$$testability', function() {
       expect(names[0]).toBe(element.find('li')[0]);
     });
 
+    it('should find bindings with allowed special characters', function() {
+      element =
+          '<div>' +
+          '  <span>{{$index}}</span>' +
+          '  <span>{{foo.bar}}</span>' +
+          '  <span>{{foonbar}}</span>' +
+          '  <span>{{foo | uppercase}}</span>' +
+          '</div>';
+      element = $compile(element)(scope);
+      var indexes = $$testability.findBindings(element[0], '$index', true);
+      expect(indexes.length).toBe(1);
+      expect(indexes[0]).toBe(element.find('span')[0]);
+
+      var foobars = $$testability.findBindings(element[0], 'foo.bar', true);
+      expect(foobars.length).toBe(1); // it should not match {{foonbar}}
+      expect(foobars[0]).toBe(element.find('span')[1]);
+
+      var foo = $$testability.findBindings(element[0], 'foo', true);
+      expect(foo.length).toBe(1); // it should match {{foo | uppercase}}
+      var uppercase = $$testability.findBindings(element[0], 'uppercase', true);
+      expect(uppercase.length).toBe(1); // it should match {{foo | uppercase}}
+      var filteredFoo = $$testability.findBindings(element[0], 'foo | uppercase', true);
+      expect(filteredFoo.length).toBe(1); // it should match {{foo | uppercase}}
+      expect(filteredFoo[0]).toBe(element.find('span')[3]);
+    });
+
     it('should find partial models', function() {
       element =
           '<div>' +