New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client classes with components #5

Open

wglass opened this issue Feb 23, 2016 · 0 comments

Assignees

Labels

2 - Working <= 5 enhancement

Milestone

Owner

wglass commented Feb 23, 2016

As of right now the client classes are fairly simple and have a simple inheritance chain.

To tack on the option to use 0.9 apis complicates things, and a combo Worker class complicates them
further.

In order to avoid copy pasta the clients should be broken up into components based on functionality.

possible components

Grouped by Zoookeeper
Grouped by Kafka (the 0.9 group membership apis)
Offsets kept in memory with options to use BEGINNING or END or datetime/timedelta
Offsets fetched and committed
messages produced to a topic (would be used by Producer and Worker)

wglass self-assigned this

wglass added this to the 1.1.0 milestone

wglass added 0 - Backlog enhancement 2 - Working <= 5 and removed 0 - Backlog labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment