Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution Context Issues #56

Open
joearasin opened this issue Sep 28, 2016 · 4 comments
Open

Execution Context Issues #56

joearasin opened this issue Sep 28, 2016 · 4 comments
Milestone

Comments

@joearasin
Copy link

When I mix in a DockerKit in with AsyncFlatSpec from Scalatest3, I'm getting a "ambiguous implicit values" error because both are creating an execution context. I think the right behavior is for DockerKit to either depend on an externally-provided ExecutionContext, or not allow it's executionContext to be exposed to the outside world.

@viktortnk
Copy link
Contributor

Maybe we should change it so that all internal blocking calls are executed on special ExecutionContext (which will be possible to override), and transformations map, flatMap, etc. are performed on Implicit global

@kelveden
Copy link

A related problem is that this has caused interesting behaviour in our tests where we're relying on creating new threads within the test (e.g. creating futures which are then Awaited on) - the workaround has been to override the dockerExecutionContext implicit in our test suite.

@viktortnk
Copy link
Contributor

Sorry, I know this ExecutionContext stuff is a big mess at the moment. it is hard to track to what's going on. I'm working on addressing this issue in new version (0.10). Will keep it open

@viktortnk viktortnk added this to the 0.10.0 milestone Sep 15, 2017
@Jokser
Copy link

Jokser commented Oct 20, 2017

I had the same issue. Btw, why not just make execution context for docker as private? It helped to me, but I had to copy-paste DockerKit and DockerTestKit to make that change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants