From a04997c81f78746fdd44f8b6b3058bcc13ef39ad Mon Sep 17 00:00:00 2001
From: Chinmay Garde <chinmaygarde@google.com>
Date: Wed, 14 Dec 2022 18:27:17 -0800
Subject: [PATCH] [Impeller] Disable impeller_unittests. (#38307)

Fixes https://github.com/flutter/flutter/issues/114872
Followup in https://github.com/flutter/flutter/issues/117122
---
 testing/run_tests.py | 40 +++++++++++++++++++++-------------------
 1 file changed, 21 insertions(+), 19 deletions(-)

diff --git a/testing/run_tests.py b/testing/run_tests.py
index 9d4603df027cd..875b0ef88ccfb 100755
--- a/testing/run_tests.py
+++ b/testing/run_tests.py
@@ -440,26 +440,28 @@ def make_test(name, flags=None, extra_env=None):
         shuffle_flags,
         coverage=coverage
     )
+    # TODO(117122): Re-enable impeller_unittests after shader compiler errors
+    #               are addressed.
     # Impeller tests are only supported on macOS for now.
-    run_engine_executable(
-        build_dir,
-        'impeller_unittests',
-        executable_filter,
-        shuffle_flags,
-        coverage=coverage,
-        extra_env={
-            # pylint: disable=line-too-long
-            # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
-            'MTL_SHADER_VALIDATION':
-                '1',  # Enables all shader validation tests.
-            'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
-                '1',  # Validates accesses to device and constant memory.
-            'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
-                '1',  # Validates accesses to threadgroup memory.
-            'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
-                '1',  # Validates that texture references are not nil.
-        }
-    )
+    # run_engine_executable(
+    #     build_dir,
+    #     'impeller_unittests',
+    #     executable_filter,
+    #     shuffle_flags,
+    #     coverage=coverage,
+    #     extra_env={
+    #         # pylint: disable=line-too-long
+    #         # See https://developer.apple.com/documentation/metal/diagnosing_metal_programming_issues_early?language=objc
+    #         'MTL_SHADER_VALIDATION':
+    #             '1',  # Enables all shader validation tests.
+    #         'MTL_SHADER_VALIDATION_GLOBAL_MEMORY':
+    #             '1',  # Validates accesses to device and constant memory.
+    #         'MTL_SHADER_VALIDATION_THREADGROUP_MEMORY':
+    #             '1',  # Validates accesses to threadgroup memory.
+    #         'MTL_SHADER_VALIDATION_TEXTURE_USAGE':
+    #             '1',  # Validates that texture references are not nil.
+    #     }
+    # )
 
 
 def parse_impeller_vulkan_filter():