Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] cola-plum-dispatch conflicts with the original plum-dispatch in downstream code using cola #103

Open
vabor112 opened this issue Sep 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@vabor112
Copy link

vabor112 commented Sep 3, 2024

🐛 Bug

The cola-plum-dispatch fork conflicts with the original plum-dispatch dependency in downstream libraries using cola.

plum-dispatch is on version 2.5.2 now, while cola-plum-dispatch more or less corresponds to version 2.2.1 thereof. The fork, however, occupies the same namespace (plum) and thus both cannot be used at the same time.

To reproduce

> pip install -q plum-dispatch
> python -c "import plum; print(plum.__version__)"
2.5.2
> pip install -q cola-ml
> python -c "import plum; print(plum.__version__)"
0.1.4

Expected Behavior

It would make sense to give cola-plum-dispatch a separate name, so that it does not override the actual plum-dispatch.

System information

Please complete the following information:

  • CoLA Version: 0.0.5.
  • JaX Version: 0.4.31
  • macOS 14.2.1

Additional context

This should be an easy-fix from your side but this is a very big problem downstream. See JaxGaussianProcesses/GPJax#441 and JiaYaobo/fenbux#1.

@thomaspinder
Copy link

Bumping this issue. Would also love to see a fix for this implemented upstream in cola-ml

@vabor112
Copy link
Author

A kind reminder. @AndPotap, perhaps you could help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants