Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put JsonRpcServer into its own Arbiter #176

Open
aesedepece opened this issue Nov 22, 2018 · 1 comment
Open

Put JsonRpcServer into its own Arbiter #176

aesedepece opened this issue Nov 22, 2018 · 1 comment
Labels
enhancement 📈 New feature or request security 🛡️ Changes that affect software security for the good or the bad

Comments

@aesedepece
Copy link
Member

aesedepece commented Nov 22, 2018

Context

Flooding JsonRpcServer with dummy messages makes the entire System unresponsive as it runs on a single system thread which is shared by every actor in our app.

We need to isolate JsonRpcServer into its own Arbiter so that it can run on a separate thread and not block the rest of our actors.

If this works well, it will be useful as a PoC for a more general strategy for actor arbitration and safe isolation of different parts of our apps, which is important for #72.

@aesedepece aesedepece added the enhancement 📈 New feature or request label Nov 22, 2018
@mariocao mariocao added the security 🛡️ Changes that affect software security for the good or the bad label Jul 27, 2020
@mariocao
Copy link
Contributor

This issue is still relevant as it is an attack vector for those nodes with public Json RPC server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 📈 New feature or request security 🛡️ Changes that affect software security for the good or the bad
Projects
None yet
Development

No branches or pull requests

2 participants