Fix generated for Href helper for param-less actions

Author: raphael

goagen/gen_app/writers.go

@@ -752,8 +752,9 @@ func {{ .Unmarshal }}(ctx context.Context, service *goa.Service, req *http.Reque
 	resourceT = `{{ if .CanonicalTemplate }}// {{ .Name }}Href returns the resource href.
 func {{ .Name }}Href({{ if .CanonicalParams }}{{ join .CanonicalParams ", " }} interface{}{{ end }}) string {
 {{ range $param := .CanonicalParams }}	param{{$param}} := strings.TrimLeftFunc(fmt.Sprintf("%v", {{$param}}), func(r rune) bool { return r == '/' })
-{{ end }}	return fmt.Sprintf("{{ .CanonicalTemplate }}", param{{ join .CanonicalParams ", param" }})
-}
+{{ end }}{{ if .CanonicalParams }}	return fmt.Sprintf("{{ .CanonicalTemplate }}", param{{ join .CanonicalParams ", param" }})
+{{ else }}	return "{{ .CanonicalTemplate }}"
+{{ end }}}
 {{ end }}`
 
 	// mediaTypeT generates the code for a media type.

goagen/gen_app/writers_test.go

@@ -905,6 +905,22 @@ var _ = Describe("HrefWriter", func() {
 						Ω(written).Should(ContainSubstring(simpleResourceHref))
 					})
 				})
+
+				Context("and a canonical action with no param", func() {
+					BeforeEach(func() {
+						canoTemplate = "/bottles"
+					})
+
+					It("writes the href method", func() {
+						err := writer.Execute(data)
+						Ω(err).ShouldNot(HaveOccurred())
+						b, err := ioutil.ReadFile(filename)
+						Ω(err).ShouldNot(HaveOccurred())
+						written := string(b)
+						Ω(written).ShouldNot(BeEmpty())
+						Ω(written).Should(ContainSubstring(noParamHref))
+					})
+				})
 			})
 		})
 	})
@@ -1481,5 +1497,9 @@ type BottlesController interface {
 	paramid := strings.TrimLeftFunc(fmt.Sprintf("%v", id), func(r rune) bool { return r == '/' })
 	return fmt.Sprintf("/bottles/%v", paramid)
 }
+`
+	noParamHref = `func BottleHref() string {
+	return "/bottles"
+}
 `
 )