Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove authentication checks from POST/PATCH/DELETE requests #106

Closed
wopian opened this issue Jan 24, 2018 · 0 comments
Closed

Remove authentication checks from POST/PATCH/DELETE requests #106

wopian opened this issue Jan 24, 2018 · 0 comments
Assignees
Milestone

Comments

@wopian
Copy link
Owner

wopian commented Jan 24, 2018

kitsu currently throws an error if POST/PATCH/DELETE requests are attempted without the Authorization header being set.

This poses an issue in 2 places:

  • APIs using non-standard headers for their authentication system (e.g. X-Something)
  • APIs that allow guest usage (e.g comments) where authentication is not needed to send POST requests.

In both cases, if an unauthenticated request is to an endpoint that requires authentication, the JSON:API API returns its own (403) error in the expected JSON:API error format.

@wopian wopian added this to the 5.0.0 milestone Jan 24, 2018
@wopian wopian self-assigned this Jan 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant