Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wsh/asdf
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: asdf-vm/asdf
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.

Commits on Dec 3, 2019

  1. Copy the full SHA
    c901466 View commit details

Commits on Dec 4, 2019

  1. Output different warning for empty and missing version

    1. when `.tool-versions` is not set
    2. when `.tool-versions` set version that is not installed
    tejanium committed Dec 4, 2019
    Copy the full SHA
    026aa78 View commit details

Commits on Dec 9, 2019

  1. Copy the full SHA
    5ca74a8 View commit details
  2. Merge pull request asdf-vm#612 from superhawk610/patch-1

    docs: update plugin-* usage
    vic authored Dec 9, 2019
    Copy the full SHA
    608098c View commit details
  3. Copy the full SHA
    5bb651a View commit details

Commits on Dec 10, 2019

  1. Merge pull request asdf-vm#614 from aocole/patch-1

    Update installation for Zsh on macOS Catalina
    vic authored Dec 10, 2019
    Copy the full SHA
    8826dc7 View commit details

Commits on Dec 13, 2019

  1. Merge pull request asdf-vm#609 from tejanium/clearer-warning

    Clarify instructions when <version> of a <shim_name> is missing.
    vic authored Dec 13, 2019
    Copy the full SHA
    ff57001 View commit details

Commits on Dec 16, 2019

  1. Release 0.7.6

    vic committed Dec 16, 2019
    Copy the full SHA
    39d3773 View commit details
  2. Update version to 0.7.6

    vic committed Dec 16, 2019
    Copy the full SHA
    6207e42 View commit details

Commits on Dec 20, 2019

  1. Fix issue with preset version warning assuming that the shim name and…

    … plugin name are the same
    Luke Bonaccorsi committed Dec 20, 2019
    Copy the full SHA
    c728018 View commit details

Commits on Dec 21, 2019

  1. Run config tests in BATS_TMPDIR for clean environment

    This avoids issues with it picking up config files from parent
    directories.
    jonmast committed Dec 21, 2019
    Copy the full SHA
    67e0e50 View commit details
  2. Ignore shim directory for executable lookups

    Previously, the shims directory was only excluded for system versions,
    which meant that `asdf exec` would fall back to a shim if the install
    didn't have the desired binary. If the shims are up to date this isn't a
    problem since we check the metadata, but it causes issues if those are
    out of sync for whatever reason.
    
    I've checked all the uses of this function and I'm not seeing anywhere
    we should need the old behavior.
    jonmast committed Dec 21, 2019
    Copy the full SHA
    069c74f View commit details

Commits on Dec 22, 2019

  1. Merge pull request asdf-vm#622 from CodeFoodPixels/clearer-warning-sh…

    …im-plugin
    
    Fix issue with preset version warning assuming that the shim name and plugin name are the same
    vic authored Dec 22, 2019
    Copy the full SHA
    c34b7ec View commit details

Commits on Dec 24, 2019

  1. Update workflow.yml

    BSKY authored Dec 24, 2019
    Copy the full SHA
    40dea1e View commit details

Commits on Dec 30, 2019

  1. Merge pull request asdf-vm#624 from imbsky/patch-1

    Bump checkout action version
    danhper authored Dec 30, 2019
    Copy the full SHA
    550f286 View commit details
  2. Removes echo overcomplication

    deiga committed Dec 30, 2019
    Copy the full SHA
    340b027 View commit details
  3. Copy the full SHA
    09db5d6 View commit details

Commits on Dec 31, 2019

  1. Adds fetching of tags

    deiga committed Dec 31, 2019
    Copy the full SHA
    a3bbb0b View commit details
  2. Copy the full SHA
    5bad5f4 View commit details
  3. Defaults to empty ASDF_DATA_DIR

    If ASDF_DATA_DIR variable is undefined it will assign an empty value to
    it so bash instances running with set -o nounset can run the script
    without error.
    lalloni committed Dec 31, 2019
    Copy the full SHA
    95e0f53 View commit details

Commits on Jan 2, 2020

  1. Merge pull request asdf-vm#629 from lalloni/remove-sourced-scripts-sh…

    …ebang
    
    Remove shebang lines of sourced scripts
    Stratus3D authored Jan 2, 2020
    Copy the full SHA
    3f7bdab View commit details
  2. Fix typo

    maxnordlund authored Jan 2, 2020
    Copy the full SHA
    40600ec View commit details

Commits on Jan 3, 2020

  1. Merge pull request asdf-vm#631 from maxnordlund/patch-1

    Fix small typo `git` -> `asdf`
    Stratus3D authored Jan 3, 2020
    Copy the full SHA
    bde7ae5 View commit details

Commits on Jan 6, 2020

  1. Merge pull request asdf-vm#627 from deiga/fix-test-errors

    Fixes tests in master
    Stratus3D authored Jan 6, 2020
    Copy the full SHA
    33a3111 View commit details

Commits on Jan 15, 2020

  1. Copy the full SHA
    7d3fb89 View commit details

Commits on Jan 25, 2020

  1. Copy the full SHA
    e53de67 View commit details

Commits on Jan 28, 2020

  1. Fix bash completion for plugin-add

    Mikhail Bulash committed Jan 28, 2020
    Copy the full SHA
    0b169e1 View commit details

Commits on Jan 29, 2020

  1. Merge pull request asdf-vm#643 from mikeroll/fix-plugin-add-completion

    Fix bash completion for `plugin-add`
    Stratus3D authored Jan 29, 2020
    Copy the full SHA
    a1f76f7 View commit details
  2. Address shellcheck warnings

    Stratus3D committed Jan 29, 2020
    Copy the full SHA
    a6b8996 View commit details
  3. Merge pull request asdf-vm#637 from asdf-vm/tb/prefer-open-source

    Prefer open source distros over closed source distros in build
    Stratus3D authored Jan 29, 2020
    Copy the full SHA
    2a1c7c3 View commit details
  4. Copy the full SHA
    84ab5b7 View commit details

Commits on Jan 30, 2020

  1. Merge pull request asdf-vm#644 from asdf-vm/tb/fix-hanging-test

    Fix hanging 'asdf update is a noop for non-git repos' test
    Stratus3D authored Jan 30, 2020
    Copy the full SHA
    94db44b View commit details
  2. Update examples using subcommands

    Replace references to aliases in the form of
    `command-subcommand` with `command subcommand`
    jsejcksn committed Jan 30, 2020
    Copy the full SHA
    3a4342a View commit details

Commits on Jan 31, 2020

  1. Copy the full SHA
    79ffc55 View commit details

Commits on Feb 4, 2020

  1. Merge pull request asdf-vm#640 from asdf-vm/improve-export-shell

    Fix asdf shell xx --unset for fish
    Stratus3D authored Feb 4, 2020
    Copy the full SHA
    f787b71 View commit details
  2. Copy the full SHA
    6d8d77f View commit details

Commits on Feb 5, 2020

  1. Copy the full SHA
    1dc939b View commit details
  2. Merge pull request asdf-vm#649 from asdf-vm/tb/misc-test-improvements

    Misc. Test Improvements
    Stratus3D authored Feb 5, 2020
    Copy the full SHA
    e4a9ad6 View commit details

Commits on Feb 6, 2020

  1. Merge pull request asdf-vm#630 from lalloni/default-to-empty-asdf-dat…

    …a-dir
    
    Defaults to empty ASDF_DATA_DIR
    Stratus3D authored Feb 6, 2020
    Copy the full SHA
    e79016a View commit details

Commits on Feb 8, 2020

  1. Copy the full SHA
    42182f3 View commit details
  2. Copy the full SHA
    e4ddf56 View commit details
  3. Copy the full SHA
    c0222b0 View commit details
  4. Address linting errors

    Stratus3D committed Feb 8, 2020
    Copy the full SHA
    43bd2d2 View commit details
  5. Copy the full SHA
    29e9b46 View commit details

Commits on Feb 9, 2020

  1. Copy the full SHA
    4911678 View commit details

Commits on Feb 14, 2020

  1. Default ZSH_VERSION to empty string. (asdf-vm#656)

    This avoids borking when a user has `set -u` (a.k.a. the `nounset`
    option) enabled.
    toothbrush authored Feb 14, 2020
    Copy the full SHA
    18b07ec View commit details
  2. Copy the full SHA
    a409b33 View commit details
  3. fix: consistent use of plugin_name

    All other instances of `check_if_plugin_exists` pass the value as `plugin_name`. Minor fix for consistency.
    jthegedus authored Feb 14, 2020
    Copy the full SHA
    c69ed91 View commit details
  4. Merge pull request asdf-vm#623 from jonmast/prevent-exec-recursion

    Ignore shim directory for executable lookups
    vic authored Feb 14, 2020
    Copy the full SHA
    62c4fdb View commit details
  5. Merge pull request asdf-vm#657 from asdf-vm/fix/consistent-use-plugin…

    …name
    
    fix: consistent use of plugin_name
    vic authored Feb 14, 2020
    Copy the full SHA
    543e16e View commit details
Showing 336 changed files with 35,134 additions and 3,979 deletions.
13 changes: 13 additions & 0 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -3,6 +3,19 @@ root = true
[*]
indent_style = space
indent_size = 2
end_of_line = lf
charset = utf-8
trim_trailing_whitespace = true
insert_final_newline = true

[*.go]
indent_style = tab

[*.py]
indent_size = 4

[*.fish]
indent_size = 4

[*.md]
trim_trailing_whitespace = false
15 changes: 15 additions & 0 deletions .git-blame-ignore-revs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
# Run shfmt on bash files
b8dc5f160447baabab9c69683824512ded577254

# fix: Remove == inside [ (#1421)
d81b81f9de2dc5961624464df04cef7cafae588c

# chore: Fix ShellCheck errors in tests
407a6696c0739f5e368543c4fc1b14e41458f177
998180e3625643644603504bea75e3bcc668465f
6f64aa8d847d53f272d30bcf2532937c02826080
b5e981cf1d9a37af17e48f6a871ff692720df810
28b348a041b3dfd1898eb0073aa1e83bdae70e4a
720fd172004c9f29045eb2ad19f35eba47ae31c7
ffa018763c10de63e6548372e7eaad2ae53643d6
90ead5ea0ae06418c58a47f4c7732797af5fe336
66 changes: 66 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
## GITATTRIBUTES
#
# Details per file setting:
# text These files should be normalized (i.e. convert CRLF to LF).
# binary These files are binary and should be left untouched.
#
# Note that binary is a macro for -text -diff.
######################################################################

## AUTO-DETECT
## Handle line endings automatically for files detected as
## text and leave all files detected as binary untouched.
## This will handle all files NOT defined below.
* text=auto

## SOURCE CODE
*.bats text
*.css text
*.htm text
*.html text
*.js text
*.sh text
*.bash text
*.fish text
*.elv text
#### asdf/bin/* explicitly define as text
*asdf text
*asdf-exec text
*_asdf text
#### asdf/test/fixtures/* should be covered by * text=auto on L14

## DOCKER
*.dockerignore text
Dockerfile text

## DOCUMENTATION
*.markdown text
*.md text
*.mdwn text
*.mdown text
*.mkd text
*.mkdn text
*.mdtxt text
*.mdtext text
*.txt text
AUTHORS text
CHANGELOG text
CHANGES text
CONTRIBUTING text
COPYING text
copyright text
*COPYRIGHT* text
INSTALL text
license text
LICENSE text
NEWS text
readme text
*README* text
TODO text

## CONFIGS
.editorconfig text
.gitattributes text
.gitconfig text
*.yaml text
*.yml text
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Default owners for all the code in this repo
* @asdf-vm/core
17 changes: 0 additions & 17 deletions .github/ISSUE_TEMPLATE.md

This file was deleted.

55 changes: 55 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
name: Bug Report
description: Create a report to help us improve
title: "bug: "
labels: [bug]
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to fill out this bug report!
- type: textarea
id: description
attributes:
label: Describe the Bug
description: A clear and concise description of what the bug is.
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: Steps to Reproduce
description: Tell us what actions you performed before the issue occurred
placeholder: |
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
validations:
required: true
- type: textarea
id: expected
attributes:
label: Expected Behaviour
description: Tell us what should have happened?
validations:
required: true
- type: textarea
id: actual
attributes:
label: Actual Behaviour
description: Tell us what happened instead
validations:
required: true
- type: textarea
id: environment
attributes:
label: Environment
description: Copy the output of `asdf info` here
render: shell
validations:
required: true
- type: textarea
id: plugins
attributes:
label: asdf plugins affected (if relevant)
description: The plugins you list here should appear in the list from `asdf info`
6 changes: 6 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Force users to use one of our predefined issue templates
blank_issues_enabled: false
contact_links:
- name: Question (StackOverflow)
url: https://stackoverflow.com/questions/tagged/asdf-vm
about: Ask new or browse existing questions on StackOverflow.
16 changes: 16 additions & 0 deletions .github/ISSUE_TEMPLATE/documentation.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
name: Documentation
description: Suggest a documentation improvements for this project
labels: "documentation"
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to help improve our docs!
- type: textarea
id: problem
attributes:
label: How can we improve the documentation?
description: Please provide a clear and concise description of the problem. The more information you can provide here, the better.
placeholder: The documentation can be improved by...
validations:
required: true
38 changes: 38 additions & 0 deletions .github/ISSUE_TEMPLATE/feature_request.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Feature Request
description: Suggest an idea for this project
labels: "enhancement"
body:
- type: markdown
attributes:
value: |
Thanks for taking the time to request this feature!
- type: textarea
id: problem
attributes:
label: Is your feature request related to a problem? Please describe
description: Please provide a clear and concise description the problem this feature would solve. The more information you can provide here, the better.
placeholder: I'm always frustrated when...
validations:
required: true
- type: textarea
id: solution
attributes:
label: Describe the proposed solution
description: Please provide a clear and concise description of what you would like to happen.
placeholder: I would like to see...
validations:
required: true
- type: textarea
id: alternatives
attributes:
label: "Describe similar `asdf` features and why they are not sufficient"
description: "Describe asdf features you tried to use to accomplish what you wanted. Explain why they are insufficient for the task you were trying to accomplish."
validations:
required: true
- type: textarea
id: workarounds
attributes:
label: "Describe other workarounds you've considered"
description: "A clear and concise description of any alternative solutions or features you've considered."
validations:
required: true
7 changes: 2 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
# Summary

Provide a general description of the code changes in your pull request.
<!-- Provide a general description of the code changes in your pull request. -->

Fixes: List issue numbers here

## Other Information

If there is anything else that is relevant to your pull request include that
information here.

Thank you for contributing to asdf!
<!-- If there is anything else that is relevant to your pull request include that information here. Thank you for contributing to asdf! -->
21 changes: 21 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
version: 2
updates:
# Maintain dependencies for GitHub Actions
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "weekly"
reviewers:
- "jthegedus"
- "stratus3d"
# Maintain dependencies for npm used in Documentation site
- package-ecosystem: "npm"
directory: "/docs"
schedule:
interval: "monthly"
reviewers:
- "jthegedus"
groups:
docs:
patterns:
- "*"
59 changes: 59 additions & 0 deletions .github/workflows/documentation.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: Documentation

on:
# trigger deployment on push to master branch when changes to docs/**
push:
paths:
- "docs/**"
branches:
- master
# trigger deployment manually
workflow_dispatch:

jobs:
deploy:
runs-on: ubuntu-latest
defaults:
run:
working-directory: docs/

steps:
- uses: actions/checkout@v4
with:
# fetch all commits to get last updated time or other git log info
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "20"

- name: Cache dependencies
uses: actions/cache@v4
id: npm-cache
with:
path: |
**/node_modules
key: ${{ runner.os }}-npm-${{ hashFiles('**/package-lock.json') }}
restore-keys: |
${{ runner.os }}-npm-
- name: Install dependencies
if: steps.npm-cache.outputs.cache-hit != 'true'
run: npm install

- name: Build VitePress site
run: npm run build

- name: Bundle CNAME with site dist
run: cp CNAME .vitepress/dist

- name: Deploy to GitHub Pages
uses: crazy-max/ghaction-github-pages@v4
with:
# deploy to gh-pages branch
target_branch: gh-pages
# deploy the default output dir of VitePress
build_dir: docs/.vitepress/dist
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
54 changes: 54 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Lint

on:
push:
branches:
- master
pull_request:

env:
PYTHON_MIN_VERSION: "3.13.1"

jobs:
asdf-bash:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: asdf-vm/actions/install@v3
- uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON_MIN_VERSION }}
- run: scripts/install_dependencies.bash
- run: scripts/lint.bash --check

asdf-golang:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: '1.23.4'
- name: Install dependencies
run: go get ./...
- name: Run 'gofumpt'
run: go run mvdan.cc/gofumpt -l -w .
- name: Check format
run: '[ -z "$(gofmt -l ./...)" ]'
- name: Run 'revive'
run: go run github.com/mgechev/revive -set_exit_status ./...
- name: Vet
run: go vet ./...
- name: Lint
run: go run honnef.co/go/tools/cmd/staticcheck -tests -show-ignored ./...
- name: Build
run: go build -v ./...

actions:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Check workflow files
uses: docker://rhysd/actionlint:1.6.24
with:
args: -color
Loading