QXcbXSettings: don't construct a QByteArray just to append it

... use QByteArray::append(char*,int) instead. Also cache the return value of the out-of-line function xcb_get_property_value_length(). Saves ~120b in text size, and a heap allocation. Change-Id: I4d1deafdcd3345f2b7dfbf8c45702cfee733a269 Reviewed-by: Olivier Goffart (Woboq GmbH) <[email protected]>
wx984490083 · Jan 14, 2016 · ed45af5 · ed45af5
1 parent a836b47
commit ed45af5
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/plugins/platforms/xcb/qxcbxsettings.cpp b/src/plugins/platforms/xcb/qxcbxsettings.cpp
@@ -117,8 +117,9 @@ class QXcbXSettingsPrivate
             if (!reply)
                 return settings;
 
-            settings += QByteArray((const char *)xcb_get_property_value(reply), xcb_get_property_value_length(reply));
-            offset += xcb_get_property_value_length(reply);
+            const auto property_value_length = xcb_get_property_value_length(reply);
+            settings.append(static_cast<const char *>(xcb_get_property_value(reply)), property_value_length);
+            offset += property_value_length;
             more = reply->bytes_after != 0;
 
             free(reply);