Skip to content

Commit 4622c70

Browse files
author
Markus Armbruster
committed
qapi storage-daemon/qapi: Fix documentation section structure
In the QEMU QMP Reference Manual, subsection "Block core (VM unrelated)" is empty. Its contents is at the end of subsection "Background jobs" instead. That's because qapi/job.json is included first from qapi/block-core.json, which makes qapi/job.json's documentation go between qapi/block-core.json's subsection heading and contents. In the QEMU Storage Daemon QMP Reference Manual, section "Block Devices" contains nothing but an empty subsection "Block core (VM unrelated)". The latter's contents is at the end section "Socket data types", along with subsection "Block device exports". Subsection "Background jobs" is at the end of section "Cryptography". All this is because storage-daemon/qapi/qapi-schema.json includes modules in a confused order. Fix both as follows. Turn subsection "Background jobs" into a section. Move it before section "Block devices" in the QEMU QMP Reference Manual, by including qapi/jobs.json right before qapi/block.json. Reorder include directives in storage-daemon/qapi/qapi-schema.json to match the order in qapi/qapi-schema.json, so that the QEMU Storage Daemon QMP Reference Manual's section structure the QEMU QMP Reference Manual's. In the QEMU QMP Reference Manual, qapi/cryptodev.json's documentation is at the end of section "Virtio devices". That's because it lacks a section heading, and therefore gets squashed into whatever section happens to precede it. Add section heading so it's in section "Cryptography devices". Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Reviewed-by: Eric Blake <[email protected]> Acked-by: zhenwei pi <[email protected]> Message-Id: <[email protected]>
1 parent 94546de commit 4622c70

File tree

4 files changed

+20
-8
lines changed

4 files changed

+20
-8
lines changed

qapi/cryptodev.json

+4
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44
# This work is licensed under the terms of the GNU GPL, version 2 or later.
55
# See the COPYING file in the top-level directory.
66

7+
##
8+
# = Cryptography devices
9+
##
10+
711
##
812
# @QCryptodevBackendAlgType:
913
#

qapi/job.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# vim: filetype=python
33

44
##
5-
# == Background jobs
5+
# = Background jobs
66
##
77

88
##

qapi/qapi-schema.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,11 +43,11 @@
4343
{ 'include': 'sockets.json' }
4444
{ 'include': 'run-state.json' }
4545
{ 'include': 'crypto.json' }
46+
{ 'include': 'job.json' }
4647
{ 'include': 'block.json' }
4748
{ 'include': 'block-export.json' }
4849
{ 'include': 'char.json' }
4950
{ 'include': 'dump.json' }
50-
{ 'include': 'job.json' }
5151
{ 'include': 'net.json' }
5252
{ 'include': 'rdma.json' }
5353
{ 'include': 'rocker.json' }

storage-daemon/qapi/qapi-schema.json

+14-6
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,26 @@
1515

1616
{ 'include': '../../qapi/pragma.json' }
1717

18+
# Documentation generated with qapi-gen.py is in source order, with
19+
# included sub-schemas inserted at the first include directive
20+
# (subsequent include directives have no effect). To get a sane and
21+
# stable order, it's best to include each sub-schema just once, or
22+
# include it first right here.
23+
24+
{ 'include': '../../qapi/common.json' }
25+
{ 'include': '../../qapi/sockets.json' }
26+
{ 'include': '../../qapi/crypto.json' }
27+
{ 'include': '../../qapi/job.json' }
28+
1829
##
1930
# = Block devices
2031
##
2132
{ 'include': '../../qapi/block-core.json' }
2233
{ 'include': '../../qapi/block-export.json' }
34+
2335
{ 'include': '../../qapi/char.json' }
24-
{ 'include': '../../qapi/common.json' }
36+
{ 'include': '../../qapi/authz.json' }
37+
{ 'include': '../../qapi/transaction.json' }
2538
{ 'include': '../../qapi/control.json' }
26-
{ 'include': '../../qapi/crypto.json' }
2739
{ 'include': '../../qapi/introspect.json' }
28-
{ 'include': '../../qapi/job.json' }
29-
{ 'include': '../../qapi/authz.json' }
3040
{ 'include': '../../qapi/qom.json' }
31-
{ 'include': '../../qapi/sockets.json' }
32-
{ 'include': '../../qapi/transaction.json' }

0 commit comments

Comments
 (0)