Skip to content

Commit

Permalink
Revert "vhost: send SET_VRING_ENABLE at start/stop"
Browse files Browse the repository at this point in the history
This reverts commit 3a12f32.

In case of live migration several queues can be enabled and not only the
first one. So informing backend that only the first queue is enabled is
wrong.

Reported-by: Thibaut Collet <[email protected]>
Cc: Yuanhan Liu <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Yuanhan Liu <[email protected]>
  • Loading branch information
mstsirkin committed Nov 26, 2015
1 parent 7cf3249 commit 449e357
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions hw/virtio/vhost.c
Original file line number Diff line number Diff line change
Expand Up @@ -1226,11 +1226,6 @@ int vhost_dev_start(struct vhost_dev *hdev, VirtIODevice *vdev)
}
}

if (hdev->vhost_ops->vhost_set_vring_enable) {
/* only enable first vq pair by default */
hdev->vhost_ops->vhost_set_vring_enable(hdev, hdev->vq_index == 0);
}

return 0;
fail_log:
vhost_log_put(hdev, false);
Expand Down Expand Up @@ -1261,10 +1256,6 @@ void vhost_dev_stop(struct vhost_dev *hdev, VirtIODevice *vdev)
hdev->vq_index + i);
}

if (hdev->vhost_ops->vhost_set_vring_enable) {
hdev->vhost_ops->vhost_set_vring_enable(hdev, 0);
}

vhost_log_put(hdev, true);
hdev->started = false;
hdev->log = NULL;
Expand Down

0 comments on commit 449e357

Please sign in to comment.