Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

测试代码恳请严格通过。 #29

Open
fanlushuai opened this issue Nov 7, 2018 · 1 comment
Open

测试代码恳请严格通过。 #29

fanlushuai opened this issue Nov 7, 2018 · 1 comment

Comments

@fanlushuai
Copy link

1、com.tencent.xinge.push.app.PushTagAndroidTest#testPushTagAndroid
这个方法看着是个安卓标签推送。
但是!
代码里面写的audience_type设置的缺失,导致使用了默认值。AudienceType.all
不光不是tag推送,而且是全量推送。
刚刚,我测试了一下,结果某环境全量推了,脸都绿了!!!
希望作者,修改。防止他人产生同样问题。

另外,就是默认值的问题。这种关键性的值,我觉得请不要设置默认值。严格要求上层输入。不然真的容易出问题。

2、 com.tencent.xinge.device.tag.DeviceTagRequest#tag_token_list
缺失 @jsonformat(shape = JsonFormat.Shape.ARRAY)
因为官方文档要求的是,
对list的要求是 [["tag1","token1"],["tag2","token2"]]
而不是 [{"tag":"tag1","token":"token1"}]

建议检查所有的List参数。全部加上@jsonformat(shape = JsonFormat.Shape.ARRAY)

@zengweijin
Copy link
Collaborator

感谢建议及测试!,之前由于过于仓促,导致部分代码不严谨。这里会尽快将代码,以及测试用例review 一遍。 这里也欢迎使用merge request, 来修改代码

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants