Fix shadowsocks#76: Write call overwrite err returned by Read.

Thanks for defia pointing out this bug.
y2mao · Feb 12, 2015 · 55f57aa · 55f57aa
1 parent 46c507b
commit 55f57aa
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/shadowsocks/pipe.go b/shadowsocks/pipe.go
@@ -35,7 +35,8 @@ func PipeThenClose(src, dst net.Conn, timeoutOpt int) {
 		// read may return EOF with n > 0
 		// should always process n > 0 bytes before handling error
 		if n > 0 {
-			if _, err = dst.Write(buf[0:n]); err != nil {
+			// Note: avoid overwrite err returned by Read.
+			if _, err := dst.Write(buf[0:n]); err != nil {
 				Debug.Println("write:", err)
 				break
 			}