Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert special characters, like accents to the right ASCII char code #8

Closed
Maillouski opened this issue Mar 31, 2023 · 7 comments
Closed

Comments

@Maillouski
Copy link

For example, the letter "é" should be converted to char 130(dec). Right now we get somekind of garbage.

@yeokm1
Copy link
Owner

yeokm1 commented Mar 31, 2023

Hmm... That's not a standard ASCII character. I'm not sure if DOS systems can print such an Extended ASCII character but I can check. It could be doable.

If you don't mind, can you send me the prompt you gave to ChatGPT to generate an output that has this character? Including screenshots of the garbage and the raw JSON output that has this issue.

@Maillouski
Copy link
Author

image

@Maillouski
Copy link
Author

Maillouski commented Mar 31, 2023

DOS can print those chars.
You can check the extended ASCII table using CP437 (MS-DOS default encoding) here :
https://www.rapidtables.com/code/text/ascii-table.html

@yeokm1
Copy link
Owner

yeokm1 commented Mar 31, 2023

Can I check if the expected output is supposed to be the following?

J'ai attribué
Tu as attribué
Il/Elle a attribué
Nous avons attribué
Vous avez attribué
Ils/Elles ont attribué

For "Il/Elle" and "Ils/Elles", are those actually printed in the correct way?

@Maillouski
Copy link
Author

This output is 100% correct

@yeokm1
Copy link
Owner

yeokm1 commented Mar 31, 2023

In progress

image

@yeokm1
Copy link
Owner

yeokm1 commented Apr 1, 2023

Solved in latest releases https://github.com/yeokm1/doschgpt/releases by converting from Unicode to Code Page 437

@yeokm1 yeokm1 closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants