Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to perform "segment everything" and "salient instance segmentation"?? #1

Open
xiankgx opened this issue Dec 6, 2023 · 16 comments

Comments

@xiankgx
Copy link

xiankgx commented Dec 6, 2023

Dear author, thank for releasing your model and Colab notebook on example usage. But in your Colab notebook, you demonstrated how to perform inference with box prompt and point prompt inputs. What about "segment everything" and "salient instance segmentation"? How do we do that? Can you please provide some examples.

@yformer
Copy link
Owner

yformer commented Dec 6, 2023

Hi @xiankgx, thanks for your interest in this work. For segment everything, we are cleaning our code and adding it in the Colab notebook. For salient instance segmentation, we used our internal infra for the task and it may take a while to add it in the Colab notebook. When the code is ready, we will message you here.

@xiankgx
Copy link
Author

xiankgx commented Dec 6, 2023

@yformer Thank you so much! Looking forward for that release. We're finding great use case for this.

@skylning
Copy link

Looking forward "segment everything" and "salient instance segmentation" release

@exhyy
Copy link

exhyy commented Dec 15, 2023

I tried to perform "segment everything" like the original SAM and also changed some parameters (e.g. pred_iou_thresh), but they did not work well. Looking forward for the release.

@bxl1234
Copy link

bxl1234 commented Dec 15, 2023

I am looking forward too "segment everything"

@Horatio9702
Copy link

I'm interested in segmenting salient objects, can this be done directly by using text prompts like "salient objects"?

@yformer
Copy link
Owner

yformer commented Dec 20, 2023

@xiankgx, @skylning, @exhyy, @bxl1234, @Horatio9702, The segment everything example can be seen at notebooks/EfficientSAM_segment_everything_example.ipynb. We will also add salient segmentation example.

@bxl1234
Copy link

bxl1234 commented Dec 26, 2023

@yformer I tried "segment everything" and its current execution speed is very slow, much slower than "sam". What's going on?

@yformer
Copy link
Owner

yformer commented Dec 26, 2023

@bxl1234 It should not be the case. Can you share more information?

@bxl1234
Copy link

bxl1234 commented Dec 27, 2023

@yformer WechatIMG38
I used "EfficientSAM_segment_everything_example.ipynb" to execute it without making any changes. I looked at the code and the calculation is done on the CPU. How can I use the GPU?

@UyeYwb
Copy link

UyeYwb commented Dec 27, 2023

@yformer WechatIMG38 I used "EfficientSAM_segment_everything_example.ipynb" to execute it without making any changes. I looked at the code and the calculation is done on the CPU. How can I use the GPU?

you can change .cpu()2,cuda(), its work for me!

in def run_everything_ours():
model = model.cuda()
img_tensor.cuda(),
points.reshape(1, num_pts, 1, 2).cuda(),
point_labels.reshape(1, num_pts, 1).cuda(),
model.cuda(),

@UyeYwb
Copy link

UyeYwb commented Dec 27, 2023

The speed of full segmentation inference is too slow.I cant find reason.

@ibrandiay
Copy link

@UyeYwb What is the input size of your images? how many fps did you get? Don't forget that images that are too large on input degrade the performance of your network.

@UyeYwb
Copy link

UyeYwb commented Dec 29, 2023

@UyeYwb What is the input size of your images? how many fps did you get? Don't forget that images that are too large on input degrade the performance of your network.

The input image I use is the dog image in the example.

@xiankgx
Copy link
Author

xiankgx commented Jan 1, 2024

@yformer Thank you author for your release. Great job!

@yformer
Copy link
Owner

yformer commented Dec 4, 2024

@xiankgx @skylning @UyeYwb @exhyy @bxl1234 @Horatio9702, we released efficient track anything for unified image and video segmentation, https://github.com/yformer/EfficientTAM, which also supports segment everything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants