Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add maketime function to MysqlSqlModule #656

Closed
jczuchnowski opened this issue May 23, 2022 · 2 comments
Closed

Add maketime function to MysqlSqlModule #656

jczuchnowski opened this issue May 23, 2022 · 2 comments
Labels
good first issue Good for newcomers MySQL ziohackathon

Comments

@jczuchnowski
Copy link
Member

Add support for function maketime described in the MySQL docs.

Add function to MysqlFunctionDef in MysqlSqlModule
Add test in FunctionDefSpec
@sarahotoole
Copy link
Contributor

I'll take this one ☺️

sarahotoole added a commit to sarahotoole/zio-sql that referenced this issue May 26, 2022
@sarahotoole
zio#656 Add maketime function to MysqlSqlModule
605b51e
@sarahotoole sarahotoole mentioned this issue May 26, 2022
Merged
sarahotoole added a commit to sarahotoole/zio-sql that referenced this issue May 26, 2022
@sarahotoole
zio#656 format file
a053d70
sarahotoole added a commit to sarahotoole/zio-sql that referenced this issue May 26, 2022
@sarahotoole
zio#656 format file
1a9c16f
sarahotoole added a commit to sarahotoole/zio-sql that referenced this issue May 26, 2022
@sarahotoole
zio#656 alphabetical order
5fc7463
jczuchnowski added a commit that referenced this issue May 26, 2022
@sarahotoole @jczuchnowski
#656 Add maketime function to MysqlSqlModule (#675)
a5f5c40 
* #656 Add maketime function to MysqlSqlModule

* 656 formatting

* #656 alphabetical order

Co-authored-by: Jakub Czuchnowski <[email protected]>
@jczuchnowski
Copy link
Member Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers MySQL ziohackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdegoes @sarahotoole @jczuchnowski