Skip to content

Commit 969323e

Browse files
authored
Windows: correct mistakes in the build rules (nicklockwood#1472)
- Correct the closing tag from `Directory` to match the opening tag of `StandardDirectory`. - Fix the standard directory name to a valid identifier. - Remove errant `_` in the path specifier. - Rename `Manufacturer` to `ManufacturerFolder` as the former is reserved
1 parent 5531d67 commit 969323e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

Platforms/Windows/SwiftFormat.wixproj

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<Import Project="WiXCodeSigning.targets" />
2020

2121
<PropertyGroup>
22-
<DefineConstants>ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);SWIFTFORMAT_BUILD=$(SWIFT_FORMAT_BUILD)</DefineConstants>
22+
<DefineConstants>ProductArchitecture=$(ProductArchitecture);ProductVersion=$(ProductVersion);SWIFTFORMAT_BUILD=$(SWIFTFORMAT_BUILD)</DefineConstants>
2323
</PropertyGroup>
2424

2525
<PropertyGroup Condition=" '$(ProductArchitecture)' == 'amd64' ">

Platforms/Windows/SwiftFormat.wxs

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@
1212

1313
<Media Id="1" Cabinet="SwiftFormat.cab" EmbedCab="yes" />
1414

15-
<StandardDirectory Id="%ProgramFiles64Folder%">
16-
<Directory Id="Manufacturer" Name="nicklockwood">
15+
<StandardDirectory Id="ProgramFiles64Folder">
16+
<Directory Id="ManufacturerFolder" Name="nicklockwood">
1717
<Directory Id="INSTALLDIR" Name="SwiftFormat">
1818
<Directory Id="_usr" Name="usr">
1919
<Directory Id="_usr_bin" Name="bin" />
2020
</Directory>
2121
</Directory>
2222
</Directory>
23-
</Directory>
23+
</StandardDirectory>
2424

2525
<Component Directory="_usr_bin" Id="swiftformat.exe">
2626
<File Id="swiftformat.exe" Source="$(var.SWIFTFORMAT_BUILD)\swiftformat.exe" Checksum="yes" KeyPath="yes" />

0 commit comments

Comments
 (0)