Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minSdkVersion is 21 that is too high #4

Closed
calcitem opened this issue Jun 5, 2022 · 5 comments
Closed

minSdkVersion is 21 that is too high #4

calcitem opened this issue Jun 5, 2022 · 5 comments

Comments

@calcitem
Copy link
Contributor

calcitem commented Jun 5, 2022

Can it be downgrade to lower to make more apps can use this useful plugin?

Thank you!

See: https://github.com/calcitem/Sanmill/actions/runs/2443814256

@zonble
Copy link
Owner

zonble commented Jun 6, 2022

Hi,

https://www.appbrain.com/stats/top-android-sdk-versions

SDK 21 is Android 5.0. According to AppBrain, the Android device running OS lower than 5.0 only take 1% of the whole market share. Do we really still need to support that?

@calcitem
Copy link
Contributor Author

calcitem commented Jun 6, 2022

If 1 million people use an Android app that includes this useful plug-in, that means 10,000 people can't use.

Many places are not as rich as we are, such as Africa, Latin America.

This API was supported as early as API Level 1, so there should be little risk of lowering API Level. Down to 19 is recommended, I have some Android 4.x phones and can do some testing. It is also possible to use an emulator for testing. I'd like to help with this test.

@zonble
Copy link
Owner

zonble commented Jun 6, 2022

AKAIK, Flutter supports SDK level 19 and higher and I think 19 sounds reasonable. I am working by day in Taipei time today but I can do it later.

Thanks!

@calcitem
Copy link
Contributor Author

calcitem commented Jun 6, 2022

Thanks!

感謝你在百忙之中創作了這個Plug-in並為之不斷改進!

@zonble
Copy link
Owner

zonble commented Jun 6, 2022

Fixed in 0.2.7

@zonble zonble closed this as completed Jun 6, 2022
calcitem added a commit to calcitem/Sanmill that referenced this issue Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants