Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBSCOhost: Asyncify #3067

Open
dstillman opened this issue Jun 30, 2023 · 5 comments
Open

EBSCOhost: Asyncify #3067

dstillman opened this issue Jun 30, 2023 · 5 comments
Assignees

Comments

@dstillman
Copy link
Member

https://forums.zotero.org/discussion/105903/page-not-working-with-zotero-connector

Looks like we're calling processDocuments in a loop, resulting in a 429

@zoe-translates
Copy link
Collaborator

There's a cascade of rapid-burst network requests:

doWeb for multiple -> processDocuments in loop -> callback calls doGet -> callback calls processDocuments under some conditions

I'm tempted to write some fixes, but I need to test on something, and I'm afraid that requires a subscription.

@dstillman
Copy link
Member Author

If you want to try anyway, I can test it and make final tweaks.

@zoe-translates
Copy link
Collaborator

Thanks, that would be nice. But without some live data, I can't explore the opportunity to eliminate some requests. I can only do a mechanic transformation into the async style (and maybe replace the encoding routines -- involving a custom implementation of btoa() -- with the more modern TextEncoder).

@dstillman
Copy link
Member Author

That's fine to start. It's the burst that's the worst.

@zoe-translates
Copy link
Collaborator

It's the burst that's the worst.

Nice anapestic dimeter. You really know how to motivate me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants