Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the use of the obsolete FW framework #3105

Open
zoe-translates opened this issue Aug 16, 2023 · 0 comments
Open

Replace the use of the obsolete FW framework #3105

zoe-translates opened this issue Aug 16, 2023 · 0 comments

Comments

@zoe-translates
Copy link
Collaborator

The following translator scripts make use of the FW framework, which is

  • no longer maintained;
  • no longer necessary or helpful;
  • not conforming to current best practices;
  • duplicated everywhere in the form of minified code.

Most of these translators are of considerable age, and it's conceivable that many may have stopped working.

If a translator still works, it's not necessary to rewrite it in non-FW code just for the sake of removing FW. Nevertheless, if updates are necessary in order to keep a translator functioning, that would be a good opportunity to remove FW.

List of translators using FW (38 in total):

Ab Imperio.js
AlterNet.js
American Prospect.js
APN.ru.js
ARTnews.js
ASCO Meeting Library.js
Bezneng Gajit.js
BOFiP-Impots.js
Boston Review.js
Business Standard.js
Christian Science Monitor.js
dhistory.js
DrugBank.ca.js
Encyclopedia of Chicago.js
etatar.ru.js
EurasiaNet.js
Fairfax Australia.js
Foreign Policy.js
Game Studies.js
GameSpot.js
Gasyrlar Awazy.js
IBISWorld.js
IGN.js
In These Times.js
Japan Times Online.js
Journal of Extension.js
Kommersant.js
LA Times.js
Lagen.nu.js
LiveJournal.js
Matbugat.ru.js
ProQuest PolicyFile.js
Regeringskansliet.js
RePEc - Econpapers.js
Tatpressa.ru.js
The Atlantic.js
The New Republic.js
Wikimedia Commons.js

zoe-translates added a commit to zoe-translates/translators that referenced this issue Aug 16, 2023
The translator no longer worked with the current site. The fix is
implemented using the EM translator, and the old FW code is completely
removed.

Test cases are updated and new tests are added for multiple authors and
special projects.

Note that the ISSN field is no longer added to all translated items
because in general there's no way to determine if an online article
belongs to a particular print issue under that ISSN. Further advices is
appreciated for this particular issue.

See also zotero#3105 for the FW problem.
zoe-translates added a commit to zoe-translates/translators that referenced this issue Aug 21, 2023
- The use of the FW framework is eliminated (cf. zotero#3105)
- The domain is updated (from drugbank.ca to go.drugbank.com)
- The publication title is "DrugBank Online", its self-appellation
- Molecular structure files no longer saved as attachments
- No author is added to the creators array; DrugBank is no longer listed
  as the "editor"
- Support more entry types (products, reactions, metabolites, and
  polypeptides)
- More tests added
- minVersion bumped
zoe-translates added a commit to zoe-translates/translators that referenced this issue Sep 12, 2023
- Remove FW framework code (cf. zotero#3105)
- The code now uses Embedded Metadata; item url field's value is now
  canonical URL
- Simply use "EconPapers" as libraryCatalog value
- Detect and save more types: books and book chapters
- More metadata gathered for items: DOI, keywords, numeric keyword
  codes, original date and programming language (for software)
- Better detection of PDF links in external links; save non-PDF links
  without downloading them; do not save the (possibly many) links to
  source files for software
- Updated and added test cases, including new test cases for multiples
- Bump minVersion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant