Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note editor can't format first line of text. #22

Open
fcheslack opened this issue Jul 12, 2023 · 2 comments
Open

Note editor can't format first line of text. #22

fcheslack opened this issue Jul 12, 2023 · 2 comments

Comments

@fcheslack
Copy link
Member

This is an Android UI issue just because selecting text pops up Android's selected-text menu which then blocks the formatting buttons in the editor. Not sure if there is a great fix for this, unless Android has a way to specify that the bubble should show underneath the selection in this case.
Google apps also block UI with the selected-text menu, but there are just not many instances where leaving the text selected is essential to those actions.

Android_Screenshot_note_editor

@Dima-Android
Copy link
Collaborator

Even though moving popup to the bottom does seem possible, but solutions look a bit hacky for a WebView. Also we will need to create custom cut,copy, paste buttons as apparently you can't just move native popup, and instead can show your own popup.
Maybe a better solution would be to simply make the first line of text in note editor appear a bit lower to house the height of this edit popup?
@mrtcode Could you please point out what note-editor sources should I edit to add a bit of spacing for between the note-editor's edit buttons and the first line of note's content?

@mrtcode
Copy link
Member

mrtcode commented Jul 19, 2023

I think I need to simplify the process of customizing styles for various platforms before that. I created an issue for that zotero/note-editor#56.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants