Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TagPickerScreen #87

Open
yexingsha opened this issue Nov 30, 2023 · 1 comment
Open

Improve TagPickerScreen #87

yexingsha opened this issue Nov 30, 2023 · 1 comment

Comments

@yexingsha
Copy link

yexingsha commented Nov 30, 2023

Mock in Figma.

  • Fix all top bars #78, especially there is too much space between title and search bar
  • Use 17sp for all text
  • Each row should be 44dp in height (including the divider)
  • Use the same checkbox as in Improve allitems screen select state #84
  • Use #F2F2F7 for selected tag background
  • Dividers should start at 16dp (aligned with the checkbox), and end at the right edge of the screen
  • If possible, show colored tag dots. These dots should be 16dp, and have 16dp spacer on each side
Dima-Android added a commit that referenced this issue Dec 5, 2023
Improve single picker screen #86
Improve SortPickerScreen #85
Use material symbols for button icons #73

Dependencies update
Upping versionName to 1.0.16
@yexingsha
Copy link
Author

  • The checkbox should be 20dp in diameter but still takes up 24dp space
  • When searching for tags that contain X, the Create Tag "X" row should also use 44dp height and 17sp text
  • For long tags that overflow one line, wrap the tag instead of cutting it off. The tag should still have 16 margin to the right (currently it seems the cutoff is at the edge of the screen). The height of the row increases accordingly, so 2 lines = 66dp, 3 lines = 88dp, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant