Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings and collection edit screens #88

Open
yexingsha opened this issue Dec 1, 2023 · 0 comments
Open

Improve settings and collection edit screens #88

yexingsha opened this issue Dec 1, 2023 · 0 comments

Comments

@yexingsha
Copy link

These screens use the same layout so I will put them both here. Mock in Figma.

  • Fix all top bars #78
  • Use 17sp for all text
  • Each row should be 44dp in height, and have 16dp horizontal padding
    • In collections edit screen, both name and library/collection selection row need more padding
    • Also, the library/collection icon should be 28dp
  • Rows that open a new screen within the app need a chevron at the right
  • In the settings screen, the version number should use 13sp text, 18sp lineheight, color #8E8E92 and have 4dp spacing above
  • In collections edit screen, "Delete Collection" and "Delete Collection and Items" should be in one group, just like the "Support and Feedback" and "Privacy Policy" group in settings
Dima-Android added a commit that referenced this issue Dec 22, 2023
…on" functionality.

Improve settings and collection edit screens #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant