QRTZNET-217: Triggers fail to obey millisecond precision when setting…

… start time
00raq00 · Aug 22, 2010 · 5cdcca4 · 5cdcca4
1 parent c6cead6
commit 5cdcca4
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 2 deletions.
diff --git a/src/Quartz.Tests.Unit/CronTriggerTest.cs b/src/Quartz.Tests.Unit/CronTriggerTest.cs
@@ -69,5 +69,14 @@ public void BasicCronTriggerTest()
 
             Assert.IsNull(trigger.ComputeFirstFireTimeUtc(null));
         }
+
+        [Test]
+        public void TestPrecision()
+        {
+            Trigger trigger = new CronTrigger();
+            trigger.StartTimeUtc = new DateTime(1982, 6, 28, 13, 5, 5, 233);
+            Assert.IsFalse(trigger.HasMillisecondPrecision);
+            Assert.AreEqual(0, trigger.StartTimeUtc.Millisecond);
+        }
     }
 }
diff --git a/src/Quartz.Tests.Unit/NthIncludedDayTriggerTest.cs b/src/Quartz.Tests.Unit/NthIncludedDayTriggerTest.cs
@@ -330,5 +330,14 @@ protected override void VerifyMatch(object target, object deserialized)
 			Assert.AreEqual(targetTrigger.NextFireCutoffInterval, deserializedTrigger.NextFireCutoffInterval);
 			// Assert.AreEqual(TimeZone.getDefault(), deserializedTrigger.getTimeZone());
 		}
+
+        [Test]
+        public void TestPrecision()
+        {
+            Trigger trigger = new NthIncludedDayTrigger();
+            trigger.StartTimeUtc = new DateTime(1982, 6, 28, 13, 5, 5, 233);
+            Assert.IsFalse(trigger.HasMillisecondPrecision);
+            Assert.AreEqual(0, trigger.StartTimeUtc.Millisecond);
+        }
 	}
 }
diff --git a/src/Quartz.Tests.Unit/SimpleTriggerTest.cs b/src/Quartz.Tests.Unit/SimpleTriggerTest.cs
@@ -182,6 +182,15 @@ public void TestGetFireTimeAfter_WithCalendar()
             DateTime? fireTimeAfter = simpleTrigger.GetNextFireTimeUtc();
 
             Assert.IsNull(fireTimeAfter);
-        } 
+        }
+
+        [Test]
+        public void TestPrecision()
+        {
+            Trigger trigger = new SimpleTrigger();
+            trigger.StartTimeUtc = new DateTime(1982, 6, 28, 13, 5, 5, 233);
+            Assert.IsTrue(trigger.HasMillisecondPrecision);
+            Assert.AreEqual(233, trigger.StartTimeUtc.Millisecond);
+        }
 	}
 }
diff --git a/src/Quartz/Trigger.cs b/src/Quartz/Trigger.cs
@@ -360,7 +360,7 @@ public virtual DateTime StartTimeUtc
 					throw new ArgumentException("End time cannot be before start time");
 				}
 
-				if (HasMillisecondPrecision)
+				if (!HasMillisecondPrecision)
 				{
 					// round off millisecond...	
 					startTimeUtc = new DateTime(value.Year, value.Month, value.Day, value.Hour, value.Minute, value.Second);