Skip to content

Commit

Permalink
Add wrapper around cudaDeviceSynchronize that supports CDP joins.
Browse files Browse the repository at this point in the history
Bug 3335768
  • Loading branch information
alliepiper committed Sep 17, 2021
1 parent 1bc8794 commit fd9074b
Show file tree
Hide file tree
Showing 2 changed files with 70 additions and 1 deletion.
67 changes: 67 additions & 0 deletions cub/detail/device_synchronize.cuh
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
/*
* Copyright 2021 NVIDIA Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

#pragma once

#include <cub/util_arch.cuh>
#include <cub/util_namespace.cuh>

#include <cuda_runtime_api.h>

CUB_NAMESPACE_BEGIN

namespace detail
{

/**
* Call `cudaDeviceSynchronize()` using the proper API for the current CUB and
* CUDA configuration.
*/
CUB_RUNTIME_FUNCTION inline cudaError_t device_synchronize()
{
cudaError_t result = cudaErrorUnknown;

if (CUB_IS_HOST_CODE)
{
#if CUB_INCLUDE_HOST_CODE
result = cudaDeviceSynchronize();
#endif
}
else
{
// Device code with the CUDA runtime.
#if defined(CUB_INCLUDE_DEVICE_CODE) && defined(CUB_RUNTIME_ENABLED)

#if defined(__CUDACC__) && \
((__CUDACC_VER_MAJOR__ > 11) || \
((__CUDA_VER_MAJOR__ == 11) && (__CUDA_VER_MINOR__ >= 6)))
// CUDA >= 11.6
result = __cudaDeviceSynchronizeDeprecationAvoidance();
#else // else
result = cudaDeviceSynchronize();
#endif

#else // Device code without the CUDA runtime.
// CUDA API calls are not supported from this device.
result = cudaErrorInvalidConfiguration;
#endif
}
return result;
}

} // namespace detail

CUB_NAMESPACE_END
4 changes: 3 additions & 1 deletion cub/util_device.cuh
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@

#pragma once

#include "detail/device_synchronize.cuh"

#include "util_type.cuh"
#include "util_arch.cuh"
#include "util_debug.cuh"
Expand Down Expand Up @@ -566,7 +568,7 @@ CUB_RUNTIME_FUNCTION inline cudaError_t SyncStream(cudaStream_t stream)
#if defined(CUB_RUNTIME_ENABLED) // Device code with the CUDA runtime.
(void)stream;
// Device can't yet sync on a specific stream
result = CubDebug(cudaDeviceSynchronize());
result = CubDebug(cub::detail::device_synchronize());
#else // Device code without the CUDA runtime.
(void)stream;
// CUDA API calls are not supported from this device.
Expand Down

0 comments on commit fd9074b

Please sign in to comment.