[Feat]Avatar 컴포넌트 개발 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xilucks
requested review from
yeynii and
dohun31
and removed request for
a team
✅ Deploy Preview for life-4-cut ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
4 tasks
|
브랜치 이름이 너무 자유분방해요 |
yeynii
reviewed
Oct 12, 2023
yeynii
reviewed
Oct 12, 2023
dohun31
reviewed
Oct 13, 2023
avatar 컴포넌트 사용 간소화 랜덤 색상 생성 리뷰 반영 스토리북 코드 리뷰 반영
dohun31
reviewed
Oct 16, 2023
dohun31
reviewed
Oct 18, 2023
dohun31
approved these changes
Oct 18, 2023
yeynii
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐶 개요
Avatar 컴포넌트를 만들었습니다.
🐱 설명
세가지 종류가 있어서 하나의 Avatar 컴포넌트에서 props로 타입을 받고 원하는 컴포넌트가 리턴되게 설계했습니다.
아토믹 디자인 패턴을 따른다면 아톰 / 라벨로 분리하고 molecule에서 합쳤을거 같은데
그런건 아니라 분리해서 개발하면 복잡도만 높일거 같아서 최대한 하나의 컴포넌트 파일에서 통합하려고 생각했습니다.
🏞️ 스크린샷
🤔 참고사항