Return 404 when listing empty directory

0proto · May 24, 2015 · 98951c4 · 98951c4
1 parent fcfe656
commit 98951c4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/routergroup.go b/routergroup.go
@@ -137,7 +137,13 @@ func (group *RouterGroup) StaticFS(relativePath string, fs http.FileSystem) {
 func (group *RouterGroup) createStaticHandler(relativePath string, fs http.FileSystem) HandlerFunc {
 	absolutePath := group.calculateAbsolutePath(relativePath)
 	fileServer := http.StripPrefix(absolutePath, http.FileServer(fs))
-	return WrapH(fileServer)
+	_, nolisting := fs.(*onlyfilesFS)
+	return func(c *Context) {
+		if nolisting {
+			c.Writer.WriteHeader(404)
+		}
+		fileServer.ServeHTTP(c.Writer, c.Request)
+	}
 }
 
 func (group *RouterGroup) combineHandlers(handlers HandlersChain) HandlersChain {

diff --git a/routes_test.go b/routes_test.go
@@ -195,6 +195,7 @@ func TestRouteStaticNoListing(t *testing.T) {
 
 	w := performRequest(router, "GET", "/")
 
+	assert.Equal(t, w.Code, 404)
 	assert.NotContains(t, w.Body.String(), "gin.go")
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -195,6 +195,7 @@ func TestRouteStaticNoListing(t *testing.T) { @@
     	w := performRequest(router, "GET", "/")
+    	assert.Equal(t, w.Code, 404)
     	assert.NotContains(t, w.Body.String(), "gin.go")
     }
@@ Expand Down @@