qapi: Check for negative enum values

We don't currently check for negative enum values in qmp_output_type_enum(), this will very likely generate a segfault when triggered. However, it _seems_ that no code in tree can trigger this today. Acked-by: Michael Roth <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
0x3h · Nov 17, 2011 · 54d50be · 54d50be
1 parent 3f5bd4e
commit 54d50be
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/qapi/qmp-output-visitor.c b/qapi/qmp-output-visitor.c
@@ -190,7 +190,7 @@ static void qmp_output_type_enum(Visitor *v, int *obj, const char *strings[],
 
     assert(strings);
     while (strings[i++] != NULL);
-    if (value >= i - 1) {
+    if (value < 0 || value >= i - 1) {
         error_set(errp, QERR_INVALID_PARAMETER, name ? name : "null");
         return;
     }