Skip to content

Commit

Permalink
Revert "syscall: fix dereference of undefined pointer"
Browse files Browse the repository at this point in the history
This reverts commit bc658e4.

Some versions of gcc warn about this:

linux-user/syscall.c: In function ‘do_ioctl_rt’:
linux-user/syscall.c:5577:37: error: ‘host_rt_dev_ptr’ may be used uninitialized in this function [-Werror=uninitialized]

and in particular the Travis builds fail; they use
gcc (Ubuntu/Linaro 4.6.3-1ubuntu5) 4.6.3.

Revert the change to fix the travis builds.

Signed-off-by: Peter Maydell <[email protected]>
  • Loading branch information
pm215 committed Jul 31, 2017
1 parent 25dd0e7 commit bdf211f
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion linux-user/syscall.c
Original file line number Diff line number Diff line change
Expand Up @@ -5574,7 +5574,6 @@ static abi_long do_ioctl_rt(const IOCTLEntry *ie, uint8_t *buf_temp,
field_types, THUNK_HOST);
}
unlock_user(argptr, arg, 0);
assert(host_rt_dev_ptr);

ret = get_errno(safe_ioctl(fd, ie->host_cmd, buf_temp));
if (*host_rt_dev_ptr != 0) {
Expand Down

0 comments on commit bdf211f

Please sign in to comment.