fix: warn when using --no-bundle with --minify or --node-compat (…

…cloudflare#1500) fix: warn when using `--no-bundle` with `--minify` or `--node-compat` Co-authored-by: Cameron Robey <[email protected]>
0xYYY · Jul 19, 2022 · 0826f83 · 0826f83
1 parent 7098b1e
commit 0826f83
Show file tree

Hide file tree

Showing 3 changed files with 96 additions and 0 deletions.
diff --git a/.changeset/clean-spoons-buy.md b/.changeset/clean-spoons-buy.md
@@ -0,0 +1,7 @@
+---
+"wrangler": patch
+---
+
+fix: warn when using `--no-bundle` with `--minify` or `--node-compat`
+
+Fixes https://github.com/cloudflare/wrangler2/issues/1491
diff --git a/packages/wrangler/src/__tests__/publish.test.ts b/packages/wrangler/src/__tests__/publish.test.ts
@@ -6108,6 +6108,82 @@ addEventListener('fetch', event => {});`
 			expect(fs.readFileSync("dist/index.js", "utf-8")).toMatch(scriptContent);
 		});
 	});
+
+	describe("--no-bundle --minify", () => {
+		it("should warn that no-bundle and minify can't be used together", async () => {
+			writeWranglerToml();
+			const scriptContent = `
+			const xyz = 123; // a statement that would otherwise be compiled out
+		`;
+			fs.writeFileSync("index.js", scriptContent);
+			await runWrangler(
+				"publish index.js --no-bundle --minify --dry-run --outdir dist"
+			);
+			expect(std.warn).toMatchInlineSnapshot(`
+			"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1m\`--minify\` and \`--no-bundle\` can't be used together. If you want to minify your Worker and disable Wrangler's bundling, please minify as part of your own bundling process.[0m
+
+			"
+		`);
+		});
+
+		it("should warn that no-bundle and minify can't be used together", async () => {
+			writeWranglerToml({
+				no_bundle: true,
+				minify: true,
+			});
+			const scriptContent = `
+			const xyz = 123; // a statement that would otherwise be compiled out
+		`;
+			fs.writeFileSync("index.js", scriptContent);
+			await runWrangler("publish index.js --dry-run --outdir dist");
+			expect(std.warn).toMatchInlineSnapshot(`
+			"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1m\`--minify\` and \`--no-bundle\` can't be used together. If you want to minify your Worker and disable Wrangler's bundling, please minify as part of your own bundling process.[0m
+
+			"
+		`);
+		});
+	});
+
+	describe("--no-bundle --node-compat", () => {
+		it("should warn that no-bundle and node-compat can't be used together", async () => {
+			writeWranglerToml();
+			const scriptContent = `
+			const xyz = 123; // a statement that would otherwise be compiled out
+		`;
+			fs.writeFileSync("index.js", scriptContent);
+			await runWrangler(
+				"publish index.js --no-bundle --node-compat --dry-run --outdir dist"
+			);
+			expect(std.warn).toMatchInlineSnapshot(`
+			"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mEnabling node.js compatibility mode for built-ins and globals. This is experimental and has serious tradeoffs. Please see https://github.com/ionic-team/rollup-plugin-node-polyfills/ for more details.[0m
+
+
+			[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1m\`--node-compat\` and \`--no-bundle\` can't be used together. If you want to polyfill Node.js built-ins and disable Wrangler's bundling, please polyfill as part of your own bundling process.[0m
+
+			"
+		`);
+		});
+
+		it("should warn that no-bundle and node-compat can't be used together", async () => {
+			writeWranglerToml({
+				no_bundle: true,
+				node_compat: true,
+			});
+			const scriptContent = `
+			const xyz = 123; // a statement that would otherwise be compiled out
+		`;
+			fs.writeFileSync("index.js", scriptContent);
+			await runWrangler("publish index.js --dry-run --outdir dist");
+			expect(std.warn).toMatchInlineSnapshot(`
+			"[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1mEnabling node.js compatibility mode for built-ins and globals. This is experimental and has serious tradeoffs. Please see https://github.com/ionic-team/rollup-plugin-node-polyfills/ for more details.[0m
+
+
+			[33m▲ [43;33m[[43;30mWARNING[43;33m][0m [1m\`--node-compat\` and \`--no-bundle\` can't be used together. If you want to polyfill Node.js built-ins and disable Wrangler's bundling, please polyfill as part of your own bundling process.[0m
+
+			"
+		`);
+		});
+	});
 });
 
 /** Write mock assets to the file system so they can be uploaded. */

diff --git a/packages/wrangler/src/publish.ts b/packages/wrangler/src/publish.ts
@@ -276,6 +276,19 @@ See https://developers.cloudflare.com/workers/platform/compatibility-dates for m
 		);
 	}
 
+	// Warn if user tries minify or node-compat with no-bundle
+	if (props.noBundle && minify) {
+		logger.warn(
+			"`--minify` and `--no-bundle` can't be used together. If you want to minify your Worker and disable Wrangler's bundling, please minify as part of your own bundling process."
+		);
+	}
+
+	if (props.noBundle && nodeCompat) {
+		logger.warn(
+			"`--node-compat` and `--no-bundle` can't be used together. If you want to polyfill Node.js built-ins and disable Wrangler's bundling, please polyfill as part of your own bundling process."
+		);
+	}
+
 	const scriptName = props.name;
 	assert(
 		scriptName,