pdb: Fix CID 1427620 Resource leak

It's not exactly a resource leak (we only really realloc if we shrink dramatically), but assigning the result from tdb_realloc looks nicer. Signed-off-by: Volker Lendecke <[email protected]> Reviewed-by: Ralph Boehme <[email protected]>
17500mph · Jan 17, 2018 · 4e5c942 · 4e5c942
1 parent 92131d0
commit 4e5c942
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/source3/passdb/pdb_samba_dsdb.c b/source3/passdb/pdb_samba_dsdb.c
@@ -3741,7 +3741,8 @@ static NTSTATUS pdb_samba_dsdb_enum_trusted_domains(struct pdb_methods *m,
 		domains[di++] = d;
 	}
 
-	talloc_realloc(domains, domains, struct pdb_trusted_domain *, di);
+	domains = talloc_realloc(domains, domains, struct pdb_trusted_domain *,
+				 di);
 	*_domains = talloc_move(mem_ctx, &domains);
 	*_num_domains = di;
 	TALLOC_FREE(tmp_ctx);