Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

18F Folks blog post #4130

Merged
merged 5 commits into from
Oct 25, 2024
Merged

18F Folks blog post #4130

merged 5 commits into from
Oct 25, 2024

Conversation

neilmb
Copy link
Contributor

@neilmb neilmb commented Oct 21, 2024

Pull request summary

https://github.com/18F/TLC-crew/issues/960 requests adding this post to the 18F blog.

Reminder - please do the following before assigning reviewer

  • For content changes beyond typos, add Ron Bronson as a reviewer

And make sure that automated checks are ok

  • fix houndci feedback
  • ensure tests pass
  • federalist builds
  • no new SNYK vulnerabilities are introduced

@neilmb neilmb requested a review from quarterback October 21, 2024 19:40
@neilmb neilmb requested a review from a team as a code owner October 21, 2024 19:40
Copy link

@nateborr nateborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ The preview looks great and the markdown and assets are in order.

@neilmb
Copy link
Contributor Author

neilmb commented Oct 25, 2024

@quarterback This is ready to go now, @mitogi approved on Slack and tests pass.

Do you need to approve this PR? And are there any other approvals that are needed beyond that?

@quarterback quarterback merged commit d3771a8 into main Oct 25, 2024
8 checks passed
@quarterback quarterback deleted the nmb/960-folks-post branch October 25, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants