Adds Etags on attachments.

git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@9963 e93f8b46-1217-0410-a6f0-8f06a7374b81
1richards · Jul 8, 2012 · 2dbabde · 2dbabde
1 parent e74d4ec
commit 2dbabde
Showing 1 changed file with 12 additions and 9 deletions.
diff --git a/app/controllers/attachments_controller.rb b/app/controllers/attachments_controller.rb
@@ -52,19 +52,22 @@ def download
       @attachment.increment_download
     end
 
-    # images are sent inline
-    send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
-                                    :type => detect_content_type(@attachment),
-                                    :disposition => (@attachment.image? ? 'inline' : 'attachment')
-
+    if stale?(:etag => @attachment.digest)
+      # images are sent inline
+      send_file @attachment.diskfile, :filename => filename_for_content_disposition(@attachment.filename),
+                                      :type => detect_content_type(@attachment),
+                                      :disposition => (@attachment.image? ? 'inline' : 'attachment')
+    end
   end
 
   def thumbnail
     if @attachment.thumbnailable? && Setting.thumbnails_enabled? && thumbnail = @attachment.thumbnail
-      send_file thumbnail,
-        :filename => filename_for_content_disposition(@attachment.filename),
-        :type => detect_content_type(@attachment),
-        :disposition => 'inline'
+      if stale?(:etag => thumbnail)
+        send_file thumbnail,
+          :filename => filename_for_content_disposition(@attachment.filename),
+          :type => detect_content_type(@attachment),
+          :disposition => 'inline'
+      end
     else
       # No thumbnail for the attachment or thumbnail could not be created
       render :nothing => true, :status => 404