-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace try:/expect: by 'with pytest.raise(ValueError):' #80
Conversation
The Travis CI build failed only on test_empty_schema_file in test_command_line.py as I explain in my commit. |
OK, issue Empty schema issue is well fix, test was baddy written, I fix it by adding on data file and run test on it. |
test_bad_dir test works |
command_line._router( | ||
'yamale/tests/command_line_fixtures/empty_schema', | ||
'yamale/tests/command_line_fixtures/empty_schema/data.yaml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice find! This test was missing the final assert False
. Please add the data.yaml
file to git. Thanks!
I'm curious why the tests never completed. How do you run the tests? Can you run I agree with this PR, I would just like to know why it was hanging. Thanks! |
With non empty data.yaml that git commit accept as change |
I'm very beginner in Python
I continue with pytest |
Can you try running in an virtual environment:
|
On my Linux box, running test_command_line.py never end.
I search in Google and found nothing.
I disable all test inside and add them one by one, only tests with try/expect: stuck pytest
I Google how to expect exception with pytest: asserting exceptions with pytest
I replace all try:/expect: with pytest.raise() and then: