Skip to content

Commit

Permalink
Allow limiting kraken pairs to --pairs selection
Browse files Browse the repository at this point in the history
  • Loading branch information
xmatthias committed Feb 10, 2024
1 parent adf63a4 commit f89147f
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
7 changes: 7 additions & 0 deletions freqtrade/data/converter/trade_converter_kraken.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ def import_kraken_trades_from_csv(config: Config, convert_to: str):
}
logger.info(f"Found csv files for {', '.join(data_symbols)}.")

if pairs := config.get('pairs'):
markets = [m for m in markets if m[0] in pairs]
if not markets:
logger.info(f"No data found for pairs {', '.join(pairs)}.")
return
logger.info(f"Converting pairs: {', '.join(m[0] for m in markets)}.")

for pair, name in markets:
dfs = []
# Load and combine all csv files for this pair
Expand Down
8 changes: 8 additions & 0 deletions tests/data/test_trade_converter_kraken.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ def test_import_kraken_trades_from_csv(testdatadir, tmp_path, caplog, default_co

import_kraken_trades_from_csv(default_conf_usdt, 'feather')
assert log_has("Found csv files for BCHEUR.", caplog)
assert log_has("Converting pairs: BCH/EUR.", caplog)
assert log_has_re(r"BCH/EUR: 340 trades.* 2023-01-01.* 2023-01-02.*", caplog)

assert dstfile.is_file()
Expand All @@ -48,3 +49,10 @@ def test_import_kraken_trades_from_csv(testdatadir, tmp_path, caplog, default_co
tzinfo=timezone.utc)
# ID is not filled
assert len(trades.loc[trades['id'] != '']) == 0

caplog.clear()
default_conf_usdt['pairs'] = ['XRP/EUR']
# Filtered to non-existing pair
import_kraken_trades_from_csv(default_conf_usdt, 'feather')
assert log_has("Found csv files for BCHEUR.", caplog)
assert log_has("No data found for pairs XRP/EUR.", caplog)

0 comments on commit f89147f

Please sign in to comment.