Skip to content

Commit

Permalink
Remove --disable-service-auth-codes (flutter#45356)
Browse files Browse the repository at this point in the history
Discovered by a leakage as described in flutter/flutter#133824, this arg has likely been removed by Dart. Removing this arg eliminates the leakage warning.

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
  • Loading branch information
dkwingsmt authored Sep 2, 2023
1 parent 5f0db94 commit 89f2b91
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions runtime/dart_vm.cc
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,6 @@ static const char* kDartStartPausedArgs[]{
"--pause_isolates_on_start",
};

static const char* kDartDisableServiceAuthCodesArgs[]{
"--disable-service-auth-codes",
};

static const char* kDartEndlessTraceBufferArgs[]{
"--timeline_recorder=endless",
};
Expand Down Expand Up @@ -380,11 +376,6 @@ DartVM::DartVM(const std::shared_ptr<const DartVMData>& vm_data,
PushBackAll(&args, kDartStartPausedArgs, fml::size(kDartStartPausedArgs));
}

if (settings_.disable_service_auth_codes) {
PushBackAll(&args, kDartDisableServiceAuthCodesArgs,
fml::size(kDartDisableServiceAuthCodesArgs));
}

if (settings_.endless_trace_buffer || settings_.trace_startup) {
// If we are tracing startup, make sure the trace buffer is endless so we
// don't lose early traces.
Expand Down

0 comments on commit 89f2b91

Please sign in to comment.