Skip to content

Commit

Permalink
Make sure run_tests.py runs dart tests on Skia (flutter#49260)
Browse files Browse the repository at this point in the history
Today the default renderer on hosts is Skia, but if we ever change the default then we will be testing on Impeller+default(Impeller) rather than both Skia and Impeller. Change the flutter_tester launch arguments to explicitly disable Impeller when we want to test Skia so that we will always test on both platforms.
  • Loading branch information
flar authored Dec 19, 2023
1 parent df1593e commit 9fda016
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,8 @@ def apply_args(self, command_args):

if self.enable_impeller:
command_args += ['--enable-impeller']
else:
command_args += ['--no-enable-impeller']

if self.multithreaded:
command_args.insert(0, '--force-multithreading')
Expand Down

0 comments on commit 9fda016

Please sign in to comment.