fix: use unique s3 bucket path for each test #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
fix-s3-bucket-path
branch
from
cec0b2f to
a15df4e
Compare
stbrody
reviewed
Feb 24, 2023
There was a problem hiding this comment.
do we now how this was working in CI previously? Also is this still working in CI and just broken in local testing, or is it broken in both? Would this change cause CI to have two different timestamps appended to the end of the bucket path (not that that would be the end of the world I guess)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Running tests locally without this change breaks since the old s3 data was still around. Specifically the
local_node-privatemode test would fail since the existing s3 bucket would have information about streams from previous runs. When the node starts up it would try and find those streams in IPFS but they would not exist and the node would fail to start.How Has This Been Tested?
Running tests locally.