0033318: Data Exchange - Modifying the BRep flag after exporting the …

…shape Fixed condition for setting 'checked' flag
3drepo · May 17, 2023 · e3841f9 · e3841f9
1 parent bcfc5f0
commit e3841f9
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 3 deletions.
diff --git a/src/BinTools/BinTools_ShapeSet.cxx b/src/BinTools/BinTools_ShapeSet.cxx
@@ -479,8 +479,7 @@ void BinTools_ShapeSet::ReadFlagsAndSubs(TopoDS_Shape& S, const TopAbs_ShapeEnum
 
   S.Free(aFree);
   S.Modified(aMod);
-  if (FormatNb() != BinTools_FormatVersion_VERSION_2 &&
-      FormatNb() != BinTools_FormatVersion_VERSION_3)
+  if (FormatNb() == BinTools_FormatVersion_VERSION_1)
   {
     aChecked = false; // force check at reading
   }

diff --git a/src/TopTools/TopTools_ShapeSet.cxx b/src/TopTools/TopTools_ShapeSet.cxx
@@ -702,7 +702,7 @@ void  TopTools_ShapeSet::Read(Standard_IStream& IS, const Message_ProgressRange&
     S.Free      (buffer[0] == '1');
     S.Modified  (buffer[1] == '1');
 
-    const bool isChecked = myFormatNb == TopTools_FormatVersion_VERSION_2
+    const bool isChecked = myFormatNb >= TopTools_FormatVersion_VERSION_2
                         && buffer[2] == '1';
     S.Checked (isChecked);
 

diff --git a/tests/bugs/moddata_3/bug33318 b/tests/bugs/moddata_3/bug33318
@@ -0,0 +1,27 @@
+puts "==========================================================="
+puts "0033318: Data Exchange - Modifying the BRep flag after exporting the shape"
+puts "==========================================================="
+
+pload XDE
+
+set filepath [locate_data_file bug28620.brep]
+set f1 [open $filepath "r"]
+set string1 [read $f1]
+close $f1
+
+set conf {provider.BREP.OCC.write.binary : 0}
+
+set aTmpFile ${imagedir}/tmpfile1.brep
+readfile sh1 $filepath
+writefile sh1 $aTmpFile -conf $conf
+
+set f2 [open $aTmpFile "r"]
+set string2 [read $f2]
+close $f2
+
+set newstr [string trim $string2]
+if { [string first $newstr [string trim $string1]] == -1 } {
+  puts "Error: strings is not equal"
+}
+
+file delete -force $aTmpFile