Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/bootstrap/h2-keepalive-xds-cluster #244

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix/bootstrap/h2-keepalive-xds-cluster #244

merged 2 commits into from
Nov 5, 2024

Conversation

roivaz
Copy link
Member

@roivaz roivaz commented Oct 31, 2024 •
edited
Loading

We have detected several occasions where after an unavailability of the xds-server, envoy pods don't reconnect once recovered. This PR adds http2 keepalive PING to the xds cluster configuration so envoy proxies properly detect when the grpc connection is dead.

/kind bug
/priority important-soon
/assign

@3scale-robot
Copy link
Contributor

@roivaz: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

We have detected several occasions where after an unavailability of the xds-server, envoy pods don't reconnect once recovered. This PR adds http2 keepalive PING to the xds cluster so envoy proxies properly detect when the grpc connection is dead.

/kind fix
/priority important-soon
/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@3scale-robot 3scale-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. do-not-merge/work-in-progress labels Oct 31, 2024
@3scale-robot 3scale-robot added needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. size/S Requires less than a day to complete the PR or the issue. and removed needs-size Indicates a PR or issue lacks a `size/foo` label and requires one. labels Oct 31, 2024
@roivaz roivaz force-pushed the fix/bootstrap/h2-keepalive-xds-cluster branch from 6d6d4d8 to 046f343 Compare November 4, 2024 10:53
@3scale-robot 3scale-robot added size/M Requires about a day to complete the PR or the issue. and removed size/S Requires less than a day to complete the PR or the issue. labels Nov 4, 2024
@roivaz roivaz force-pushed the fix/bootstrap/h2-keepalive-xds-cluster branch from 046f343 to 0a19b1c Compare November 4, 2024 14:35
@roivaz roivaz added the kind/bug Categorizes issue or PR as related to a bug. label Nov 4, 2024
@3scale-robot 3scale-robot removed the needs-kind Indicates a PR or issue lacks a `kind/foo` label and requires one. label Nov 4, 2024
@roivaz
Copy link
Member Author

roivaz commented Nov 4, 2024

/retitle fix/bootstrap/h2-keepalive-xds-cluster

@3scale-robot 3scale-robot changed the title [WIP] fix/bootstrap/h2-keepalive-xds-cluster fix/bootstrap/h2-keepalive-xds-cluster Nov 4, 2024
@roivaz
Copy link
Member Author

roivaz commented Nov 4, 2024

@raelga @slopezz this can now be reviewed

@roivaz roivaz force-pushed the fix/bootstrap/h2-keepalive-xds-cluster branch from 0a19b1c to 1176b7d Compare November 4, 2024 14:54
@roivaz
Bump release
f9cce31 
Signed-off-by: Roi Vazquez <[email protected]>
@roivaz roivaz force-pushed the fix/bootstrap/h2-keepalive-xds-cluster branch from 1176b7d to f9cce31 Compare November 4, 2024 14:55
@3scale-robot 3scale-robot added size/S Requires less than a day to complete the PR or the issue. and removed size/M Requires about a day to complete the PR or the issue. labels Nov 4, 2024
@3scale-robot 3scale-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@3scale-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a5fa1930b42e44f71c85e8f11d645998a8beb52

@roivaz
Copy link
Member Author

roivaz commented Nov 5, 2024

/approve

@3scale-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3scale-robot 3scale-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@3scale-robot 3scale-robot merged commit 7cb19c9 into main Nov 5, 2024
4 checks passed
@3scale-robot 3scale-robot deleted the fix/bootstrap/h2-keepalive-xds-cluster branch November 5, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slopezz slopezz slopezz approved these changes

@raelga raelga Awaiting requested review from raelga

Assignees

@roivaz roivaz

@slopezz slopezz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next sprint. size/S Requires less than a day to complete the PR or the issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roivaz @3scale-robot @slopezz