-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch build to TS + all tests 🎉 #1038
base: master
Are you sure you want to change the base?
Conversation
Damn man this awesome. |
i've taken a better glance at build differences - all seem to be related to code-splitting, here they are(left is old right is new)
So yeah, i think merging this probably won't introduce anything wrong, but since it's a whole switch from JS->TS i expect that some slight issues might come up Overall I'd say this is ready to be merged(like I said, I expect issues to be small to nonexistent with this), although I'd understand if we want to turn this into a feature branch or something. I'd say we should face it head on and merge this and then deal with any issues while releasing 😄 but that's just me |
above and beyonce
things done: