Silence some warnings

5chmidt · Dec 22, 2021 · 556813d · 556813d
1 parent 4ab81bb
commit 556813d
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 11 deletions.
diff --git a/engine/class_modules/priest/sc_priest_pets.cpp b/engine/class_modules/priest/sc_priest_pets.cpp
@@ -654,7 +654,7 @@ action_t* priest_pallid_command_t::create_action( util::string_view name, util::
   }
 
   return priest_pet_t::create_action( name, options_str );
-};
+}
 // ==========================================================================
 // Living Shadow T28 4-set (Your Shadow)
 // ==========================================================================

diff --git a/engine/class_modules/sc_demon_hunter.cpp b/engine/class_modules/sc_demon_hunter.cpp
@@ -124,7 +124,7 @@ soul_fragment operator&( soul_fragment l, soul_fragment r )
   return static_cast<soul_fragment> ( static_cast<unsigned>( l ) & static_cast<unsigned>( r ) );
 }
 
-soul_fragment operator|( soul_fragment l, soul_fragment r )
+[[maybe_unused]] soul_fragment operator|( soul_fragment l, soul_fragment r )
 {
   return static_cast<soul_fragment> ( static_cast<unsigned>( l ) | static_cast<unsigned>( r ) );
 }
@@ -5053,7 +5053,7 @@ void demon_hunter_t::create_buffs()
     ->set_default_value( 0 )
     ->set_max_stack( 5 ) // Hard-coded, not in spell data
     ->set_constant_behavior( buff_constant_behavior::NEVER_CONSTANT )
-    ->set_stack_change_callback( [ this ]( buff_t* b, int, int new_ ) {
+    ->set_stack_change_callback( [ this ]( buff_t* b, int, int /*new_*/ ) {
       if ( b->at_max_stacks() )
       {
         // Gain is stored in spell 364134 but a server-side conditional aura (based on First Blood)

diff --git a/engine/class_modules/sc_hunter.cpp b/engine/class_modules/sc_hunter.cpp
@@ -2938,7 +2938,7 @@ struct single_target_event_t final : public event_t
 
 struct explosive_shot_munitions_t : explosive_shot_t
 {
-  explosive_shot_munitions_t( util::string_view n, hunter_t* p ) : explosive_shot_t( p, "" )
+  explosive_shot_munitions_t( util::string_view /*name*/, hunter_t* p ) : explosive_shot_t( p, "" )
   {
     background = dual = true;
   }

diff --git a/engine/class_modules/sc_rogue.cpp b/engine/class_modules/sc_rogue.cpp
@@ -7544,7 +7544,7 @@ std::unique_ptr<expr_t> rogue_t::create_expression( util::string_view name_str )
       return expr_t::create_constant( "exsanguinated_expr", 0 );
     }
 
-    return make_fn_expr( name_str, [ this, action ]() {
+    return make_fn_expr( name_str, [ action ]() {
       dot_t* d = action->get_dot( action->target );
       return d->is_ticking() && actions::rogue_attack_t::cast_state( d->state )->get_exsanguinated_rate() != 1.0;
     } );

diff --git a/engine/class_modules/warlock/sc_warlock_pets.cpp b/engine/class_modules/warlock/sc_warlock_pets.cpp
@@ -369,9 +369,9 @@ namespace demonology
 felguard_pet_t::felguard_pet_t( warlock_t* owner, util::string_view name )
   : warlock_pet_t( owner, name, PET_FELGUARD, name != "felguard" ),
     soul_strike( nullptr ),
+    demonic_strength_executes( 0 ),
     min_energy_threshold( find_spell( 89751 )->cost( POWER_ENERGY ) ),
-    max_energy_threshold( 100 ),
-    demonic_strength_executes( 0 )
+    max_energy_threshold( 100 )
 {
   action_list_str = "travel";
   action_list_str += "/demonic_strength_felstorm";

diff --git a/engine/dbc/sc_data.cpp b/engine/dbc/sc_data.cpp
@@ -66,7 +66,7 @@ bool override_bit_array_field( T* data, const Fields& fields, util::string_view
       v = std::abs( v );
     }
 
-    if ( v >= std::size( field ) * 32 )
+    if ( static_cast<unsigned>( v ) >= std::size( field ) * 32 )
       throw std::invalid_argument( "Invalid value (too large)." );
 
     int idx = v / 32;

diff --git a/engine/player/unique_gear.cpp b/engine/player/unique_gear.cpp
@@ -940,7 +940,7 @@ struct lfr_harmful_spell_t : public spell_t
 };
 
 // TODO: Ratings
-void set_bonus::passive_stat_aura( special_effect_t& effect )
+[[maybe_unused]] void set_bonus::passive_stat_aura( special_effect_t& effect )
 {
   const spell_data_t* spell = effect.player -> find_spell( effect.spell_id );
   stat_e stat = STAT_NONE;

diff --git a/engine/report/report_html_player.cpp b/engine/report/report_html_player.cpp
@@ -3917,14 +3917,15 @@ void print_html_player_results_spec_gear( report::sc_html_stream& os, const play
 
         for ( auto bonus : bonuses )
         {
-          if ( curr_tier != bonus->enum_id )
+          auto enum_id = as<int>( bonus->enum_id );
+          if ( curr_tier != enum_id )
           {
             if ( curr_tier != set_bonus_type_e::SET_BONUS_NONE )
               os << "</ul></td></tr>\n<tr class=\"left\"><th></th><td><ul class=\"float\">\n";
 
             fmt::print( os, "<li>{}</li>\n", report_decorators::decorated_set( sim, *bonus ) );
 
-            curr_tier = bonus->enum_id;
+            curr_tier = enum_id;
           }
 
           fmt::print( os, "<li>{} ({}pc)</li>\n",